feat: Integrate one click binding to sourceData of select and multi select widget by sbalaji1192 · Pull Request #25750 · appsmithorg/appsmith

sbalaji1192 · 2023-07-26T14:14:38Z

Description

We have changed the property control of sourceData of select and multi select widget to dropdowns which has one click-binding items.

PR fixes following issue(s)

Fixes #24780

Type of change

New feature (non-breaking change which adds functionality)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

Manual
Cypress

Test Plan

(https://github.com/appsmithorg/TestSmith/issues/2472)

Issues raised during DP testing

(#25750 (comment))

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Speedbreak features have been covered
Test plan covers all impacted features and areas of interest
Test plan has been peer reviewed by project stakeholders and other QA members
Manually tested functionality on DP
We had an implementation alignment call with stakeholders post QA Round 2
Cypress test cases have been added and approved by SDET/manual QA
Added Test Plan Approved label after Cypress tests were reviewed
Added Test Plan Approved label after JUnit tests were reviewed

sbalaji1192 · 2023-07-26T14:14:47Z

/build-deploy-preview skipTests=true

github-actions · 2023-07-26T14:15:11Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5669903031.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 25750.
recreate: .

sbalaji1192 · 2023-07-27T05:58:33Z

/build-deploy-preview skipTests=true

github-actions · 2023-07-27T05:58:58Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5677065219.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 25750.
recreate: .

sbalaji1192 · 2023-07-27T07:09:43Z

/build-deploy-preview skipTests=true

github-actions · 2023-07-27T07:10:05Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5677613143.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 25750.
recreate: .

github-actions · 2023-07-27T07:39:34Z

Deploy-Preview-URL: https://ce-25750.dp.appsmith.com

sbalaji1192 · 2023-07-31T12:55:51Z

/build-deploy-preview skipTests=true

github-actions · 2023-07-31T12:56:14Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5714944476.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 25750.
recreate: .

github-actions · 2023-07-31T13:26:22Z

Deploy-Preview-URL: https://ce-25750.dp.appsmith.com

sbalaji1192 · 2023-08-01T09:22:13Z

/ok-to-test

github-actions · 2023-08-01T09:22:36Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5724993049.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25750.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25750&runId=5724993049_1

github-actions · 2023-08-01T10:20:02Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5724993049.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Binding/Invalid_binding_spec.js
cypress/e2e/Regression/ClientSide/Binding/Widgets_Default_data_validation_spec.js
cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
cypress/e2e/Regression/ClientSide/OneClickBinding/MultiSelectWidget/mongoDB_spec.ts
cypress/e2e/Regression/ClientSide/Widgets/Dropdown/Dropdown_onOptionChange_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Dropdown/Dropdown_spec.js
cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect1_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect2_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect4_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect_label_value.ts
cypress/e2e/Regression/ClientSide/Widgets/Select/Select_label_value.ts
cypress/e2e/Regression/ClientSide/Widgets/Select/Select_widget1_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Select/select_Widget_Bug_spec.js
cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts
cypress/e2e/Regression/ServerSide/Params/PassingParams_Spec.ts

To know the list of identified flaky tests - Refer here

sbalaji1192 · 2023-08-01T17:16:31Z

/ok-to-test

laveena-en · 2023-08-07T05:15:08Z

/build-deploy-preview skipTests=true

github-actions · 2023-08-07T05:15:32Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5781295063.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 25750.
recreate: .

github-actions · 2023-08-07T05:39:40Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5781087932.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js
cypress/e2e/Regression/ClientSide/SettingsPane/EmbedSettings_spec.ts
cypress/e2e/Regression/ClientSide/Widgets/Dropdown/Dropdown_spec.js
cypress/e2e/Regression/ClientSide/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect1_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect2_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect4_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Select/Select_widget1_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Select/select_Widget_Bug_spec.js
cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_spec.js
cypress/e2e/Regression/ServerSide/LoginTests/LoginFailure_spec.js
cypress/e2e/Regression/ServerSide/Params/PassingParams_Spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2023-08-07T05:42:51Z

Deploy-Preview-URL: https://ce-25750.dp.appsmith.com

sbalaji1192 · 2023-08-08T04:50:26Z

/ok-to-test

github-actions · 2023-08-08T04:50:48Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5792873446.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25750.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25750&runId=5792873446_1

github-actions · 2023-08-08T05:48:51Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5792873446.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Dropdown/Dropdown_spec.js
cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect1_spec.js

To know the list of identified flaky tests - Refer here

laveena-en · 2023-08-08T07:49:46Z

Tested and verified this PR. LGTM
Test plan for coverage: #25750

Raised a separate issue for the last callout that needed design input here

Issues with suggested widgets requires BE's intervention. Discussion here

github-actions · 2023-08-08T09:27:59Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5792873446.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/BugTests/GitBugs_Spec.ts
cypress/e2e/Debugger/Widget_property_navigation_spec.ts
cypress/e2e/Widgets/Dropdown/Dropdown_spec.js
cypress/e2e/Widgets/Multiselect/MultiSelect1_spec.js

To know the list of identified flaky tests - Refer here

sbalaji1192 · 2023-08-08T09:52:51Z

/ok-to-test

github-actions · 2023-08-08T09:53:15Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5795432041.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25750.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25750&runId=5795432041_1

github-actions · 2023-08-08T10:54:08Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5795432041.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
cypress/e2e/Regression/ClientSide/Workspace/ShareAppTests_Spec.ts

To know the list of identified flaky tests - Refer here

berzerkeer · 2023-08-08T17:47:39Z

-          },
-          {
-            key: "formData.sortBy.data",
+        dynamicBindingPathList: [],


Curious , why have we removed these ?

We have added these items conditionally below

sbalaji1192 · 2023-08-09T07:33:33Z

/ok-to-test

github-actions · 2023-08-09T07:34:01Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5806199881.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25750.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25750&runId=5806199881_1

github-actions · 2023-08-09T08:32:20Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5806199881.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

init: select widget one click binding integratino

569bc7c

type fix

a4035b1

test

11ad3c4

balajisoundar added 3 commits July 31, 2023 11:44

Merge branch 'release' into feat/select-one-click-binding

b14fe1c

more changes

90e2fe1

multi select and more

9c3dc78

cypress tests

ad7838f

github-actions bot added the Enhancement New feature or request label Aug 1, 2023

balajisoundar added 2 commits August 1, 2023 21:27

test

3dfd854

cypress test fix

abef4ff

balajisoundar added 2 commits August 7, 2023 15:30

Merge branch 'release' into feat/select-one-click-binding

835919a

cypress fix

c934421

balajisoundar added 2 commits August 8, 2023 15:17

Merge branch 'release' into feat/select-one-click-binding

40ea323

cypress fix

002ea53

berzerkeer previously approved these changes Aug 8, 2023

View reviewed changes

balajisoundar added 3 commits August 9, 2023 12:11

Merge branch 'release' into feat/select-one-click-binding

dc1666b

test

debed79

cypress

db4690a

sbalaji1192 dismissed berzerkeer’s stale review via db4690a August 9, 2023 07:32

sbalaji1192 requested a review from berzerkeer August 9, 2023 07:44

berzerkeer approved these changes Aug 9, 2023

View reviewed changes

laveena-en added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Aug 9, 2023

somangshu merged commit 727d30a into release Aug 10, 2023

somangshu deleted the feat/select-one-click-binding branch August 10, 2023 05:21

Conversation

sbalaji1192 commented Jul 26, 2023 • edited by laveena-en Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

PR fixes following issue(s)

Type of change

Testing

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

Uh oh!

sbalaji1192 commented Jul 26, 2023

Uh oh!

github-actions bot commented Jul 26, 2023

Uh oh!

sbalaji1192 commented Jul 27, 2023

Uh oh!

github-actions bot commented Jul 27, 2023

Uh oh!

sbalaji1192 commented Jul 27, 2023

Uh oh!

github-actions bot commented Jul 27, 2023

Uh oh!

github-actions bot commented Jul 27, 2023

Uh oh!

sbalaji1192 commented Jul 31, 2023

Uh oh!

github-actions bot commented Jul 31, 2023

Uh oh!

github-actions bot commented Jul 31, 2023

Uh oh!

sbalaji1192 commented Aug 1, 2023

Uh oh!

github-actions bot commented Aug 1, 2023

Uh oh!

github-actions bot commented Aug 1, 2023

Uh oh!

sbalaji1192 commented Aug 1, 2023

Uh oh!

laveena-en commented Aug 7, 2023

Uh oh!

github-actions bot commented Aug 7, 2023

Uh oh!

github-actions bot commented Aug 7, 2023

Uh oh!

github-actions bot commented Aug 7, 2023

Uh oh!

sbalaji1192 commented Aug 8, 2023

Uh oh!

github-actions bot commented Aug 8, 2023

Uh oh!

github-actions bot commented Aug 8, 2023

Uh oh!

laveena-en commented Aug 8, 2023

Uh oh!

github-actions bot commented Aug 8, 2023

Uh oh!

sbalaji1192 commented Aug 8, 2023

Uh oh!

github-actions bot commented Aug 8, 2023

Uh oh!

github-actions bot commented Aug 8, 2023

Uh oh!

Uh oh!

berzerkeer Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

sbalaji1192 Aug 9, 2023

Choose a reason for hiding this comment

Uh oh!

sbalaji1192 commented Aug 9, 2023

Uh oh!

github-actions bot commented Aug 9, 2023

Uh oh!

github-actions bot commented Aug 9, 2023

Uh oh!

Reviewers

sbalaji1192 commented Jul 26, 2023 •

edited by laveena-en

Loading