Skip to content

fix: Fix version name's v prefix in info.json#29508

Merged
sharat87 merged 1 commit intoreleasefrom
fix/v
Dec 11, 2023
Merged

fix: Fix version name's v prefix in info.json#29508
sharat87 merged 1 commit intoreleasefrom
fix/v

Conversation

@sharat87
Copy link
Copy Markdown
Member

@sharat87 sharat87 commented Dec 11, 2023

Fixes #29506.

The version in info.json never had the v prefix, but we never used it for anything significant, so we never noticed it. Until in v1.9.51.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 11, 2023

Walkthrough

Walkthrough

The update involves a modification to the generate_info_json.sh script, specifically adjusting how the script determines the version number from the GITHUB_REF environment variable. This change is isolated to the script and does not impact any exported or public entities within the codebase.

Changes

File Path Change Summary
scripts/generate_info_json.sh Updated version extraction logic from GITHUB_REF

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-actions github-actions bot added Bug Something isn't working Community Reported issues reported by community members IDE Product Issues related to the IDE Product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE labels Dec 11, 2023
@sharat87 sharat87 merged commit ecf047a into release Dec 11, 2023
@sharat87 sharat87 deleted the fix/v branch December 11, 2023 09:25
sharat87 added a commit that referenced this pull request Dec 11, 2023
sharat87 added a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Community Reported issues reported by community members IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "Hey! There is a new version" pop up doesn't go away after clicking the "Refresh" button

2 participants