fix: Resolving datasource page redirection, switch env and on page load response view debugger issues by ankitakinger · Pull Request #30156 · appsmithorg/appsmith

ankitakinger · 2024-01-09T08:32:28Z

Description

Resolving datasource page redirection, switch env and on page load response view debugger issues.

PR fixes following issue(s)

Fixes #30158

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Manual
JUnit
Jest
Cypress

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Speedbreak features have been covered
Test plan covers all impacted features and areas of interest
Test plan has been peer reviewed by project stakeholders and other QA members
Manually tested functionality on DP
We had an implementation alignment call with stakeholders post QA Round 2
Cypress test cases have been added and approved by SDET/manual QA
Added Test Plan Approved label after Cypress tests were reviewed
Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

New Features
- Introduced a message prompt for the environment switching process.
- Enabled automatic generation of editor paths for datasources when not found.
Enhancements
- Improved user experience by streamlining the process of storing as a datasource in the editor.

…nse view debugger not opening issues

coderabbitai · 2024-01-09T08:32:36Z

Walkthrough

The recent updates involve enhancing the user interface components related to environment switching and datasource management. A new callback function for messaging has been introduced to the switch environment component. Additionally, there is a focus on improving the handling of editor paths for datasources, ensuring that editor paths are generated when needed, which is reflected in both the user interface and the sagas managing the application state.

Changes

File Path	Change Summary
`.../SwitchEnvironment/index.tsx`	Added a new function type property `startSwitchEnvMessage` to the `Props` interface.
`.../BottomBar/index.tsx`	Imported `START_SWITCH_ENVIRONMENT` message and passed `startSwitchEnvMessage` prop to `SwitchEnvironment` component.
`.../StoreAsDatasource.tsx` `.../DatasourceStructureNotFound.tsx` `.../DatasourcesSagas.ts`	Included a new property `generateEditorPath` set to `true` in various objects, suggesting an enhancement in the logic for generating editor paths for datasources.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

ankitakinger · 2024-01-09T08:58:36Z

/ok-to-test tags="@tag.All"

github-actions · 2024-01-09T08:59:01Z

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

github-actions · 2024-01-09T08:59:02Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7458800216.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

github-actions · 2024-01-09T09:51:02Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7458800216.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DSDiscardBugs_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js
cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts

To know the list of identified flaky tests - Refer here

ankitakinger · 2024-01-09T10:08:44Z

/ok-to-test tags="@tag.All"

github-actions · 2024-01-09T10:09:12Z

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

github-actions · 2024-01-09T10:09:13Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7459605066.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

github-actions · 2024-01-09T10:19:12Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7458800216.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DSDiscardBugs_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-09T11:13:31Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7459605066.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DSDiscardBugs_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js
cypress/e2e/Regression/ServerSide/QueryPane/DSDocs_Spec.ts
cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-09T11:25:21Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7459605066.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js
cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-09T11:37:39Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7459605066.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-09T18:16:29Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7459605066.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js

To know the list of identified flaky tests - Refer here

…o fix/modules-bugs

ankitakinger · 2024-01-09T20:41:21Z

/ok-to-test tags="@tag.All"

github-actions · 2024-01-09T20:41:45Z

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

github-actions · 2024-01-09T20:41:46Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7466657889.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

github-actions · 2024-01-09T21:32:46Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7466657889.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DSDiscardBugs_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js
cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js
cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-10T08:01:02Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7466657889.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DSDiscardBugs_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js
cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js
cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-10T09:26:43Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7466657889.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DSDiscardBugs_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js
cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-10T09:52:45Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7466657889.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DSDiscardBugs_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js
cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-10T10:27:55Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7466657889.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DSDiscardBugs_spec.ts
cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js
cypress/e2e/Regression/ServerSide/QueryPane/GoogleSheets_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-10T12:42:03Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7466657889.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/BugTests/DSDiscardBugs_spec.ts

To know the list of identified flaky tests - Refer here

github-actions · 2024-01-10T12:49:05Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7466657889.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

…ad response view debugger issues (#30156) ## Description Resolving datasource page redirection, switch env and on page load response view debugger issues. #### PR fixes following issue(s) Fixes [#30158](#30158) #### Type of change - Bug fix (non-breaking change which fixes an issue) - Chore (housekeeping or task changes that don't impact user perception) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [x] Jest - [x] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed  ## Summary by CodeRabbit - **New Features** - Introduced a message prompt for the environment switching process. - Enabled automatic generation of editor paths for datasources when not found. - **Enhancements** - Improved user experience by streamlining the process of storing as a datasource in the editor.

fixing datasource page redirection, switch env and on page load respo…

f602e15

…nse view debugger not opening issues

ankitakinger requested a review from ayushpahwa as a code owner January 9, 2024 08:32

ankitakinger changed the title ~~fixing datasource page redirection, switch env and on page load respo…~~ fix: Resolving datasource page redirection, switch env and on page load response view debugger issues Jan 9, 2024

github-actions bot added Bug Something isn't working Task A simple Todo labels Jan 9, 2024

ankitakinger requested a review from ashit-rath January 9, 2024 08:56

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

20758c6

…o fix/modules-bugs

github-actions bot added Frontend This label marks the issue or pull request to reference client code Packages Pod issues that belong to the packages pod labels Jan 9, 2024

ashit-rath approved these changes Jan 10, 2024

View reviewed changes

ankitakinger merged commit dca4682 into release Jan 10, 2024

ankitakinger deleted the fix/modules-bugs branch January 10, 2024 13:11

Conversation

ankitakinger commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

PR fixes following issue(s)

Type of change

Testing

How Has This Been Tested?

Checklist:

Dev activity

QA activity:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

Uh oh!

ankitakinger commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

ankitakinger commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

ankitakinger commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

github-actions bot commented Jan 10, 2024

Uh oh!

github-actions bot commented Jan 10, 2024

Uh oh!

github-actions bot commented Jan 10, 2024

Uh oh!

github-actions bot commented Jan 10, 2024

Uh oh!

github-actions bot commented Jan 10, 2024

Uh oh!

github-actions bot commented Jan 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ankitakinger commented Jan 9, 2024 •

edited

Loading

coderabbitai bot commented Jan 9, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)