Skip to content

chore: Vendor supervisor_stdout extension#30252

Merged
sharat87 merged 3 commits intoreleasefrom
chore/inhouse-supervisor-stdout
Jan 12, 2024
Merged

chore: Vendor supervisor_stdout extension#30252
sharat87 merged 3 commits intoreleasefrom
chore/inhouse-supervisor-stdout

Conversation

@sharat87
Copy link
Copy Markdown
Member

@sharat87 sharat87 commented Jan 12, 2024

Instead of downloading it from the github repo on every build (in base.dockerfile), we vendor the supervisor extension so we can look to fix the buffer overflow problem in supervisor logs.

After this is merged, after a day/two, we'll be removing git, python3-pip and the supervisor-stdout extension from base.dockerfile.

Summary by CodeRabbit

  • Refactor
    • Enhanced the event handling in system processes for improved logging and output management.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 12, 2024

Warning

Rate Limit Exceeded

@sharat87 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 26 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 3e31990 and eef60d0.

Walkthrough

The update involves modifying the supervisord configuration to use a new Python module for handling standard output events. The command for the stdout event listener has been changed to a Python module invocation, which likely includes custom logic for processing the output. This change centralizes the output handling to a Python script, which provides more flexibility and the potential for more complex processing compared to a simple command.

Changes

File Path Change Summary
.../supervisor/supervisord.conf
.../supervisor/appsmith_supervisor_stdout.py
Updated stdout event listener command to use a new Python module appsmith_supervisor_stdout. Added a new Python module for handling stdout and stderr with functions for output processing and an event handler.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jan 12, 2024
@sharat87
Copy link
Copy Markdown
Member Author

/ok-to-test tags="@tag.Sanity"

@github-actions
Copy link
Copy Markdown

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7496825979.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.Sanity.

@github-actions
Copy link
Copy Markdown

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7496825979.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@sharat87 sharat87 merged commit 74084ed into release Jan 12, 2024
@sharat87 sharat87 deleted the chore/inhouse-supervisor-stdout branch January 12, 2024 04:36
sharat87 added a commit that referenced this pull request Jan 22, 2024
We don't need these anymore, after changes from
#30252.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants