chore: fixes issue with disabled branch button#40163
Conversation
WalkthroughThe change updates the autocommit saga by replacing the dispatched action. The previous generic success action has been replaced with a more specific one that includes the artifact definition. Additionally, the method signature has been updated to reflect this change, ensuring that the dispatched action now carries the necessary context. Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code Definitions (1)app/client/src/git/sagas/triggerAutocommitSaga.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
## Description - Users with "developer" access to an app were finding the branch switch button disabled - The issue is occurring due to a bug in the autocommit flow. This PR fixes it Fixes appsmithorg#40162 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14337186264> > Commit: 5803065 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14337186264&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Tue, 08 Apr 2025 16:13:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the autocommit process by enhancing the success-handling logic with additional context details. This change refines how commit actions are processed, ensuring more precise state updates during the commit workflow while preserving the existing functional flow. These modifications help significantly streamline internal operations without affecting the overall seamless user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
Fixes #40162
Automation
/ok-to-test tags="@tag.Git"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14337186264
Commit: 5803065
Cypress dashboard.
Tags:
@tag.GitSpec:
Tue, 08 Apr 2025 16:13:18 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit