Skip to content

fix: remove extra nfs field in persistentVolume object#41724

Merged
wyattwalter merged 1 commit intoreleasefrom
ww-fix-helm-efs-template
Apr 8, 2026
Merged

fix: remove extra nfs field in persistentVolume object#41724
wyattwalter merged 1 commit intoreleasefrom
ww-fix-helm-efs-template

Conversation

@wyattwalter
Copy link
Copy Markdown
Contributor

@wyattwalter wyattwalter commented Apr 8, 2026

Description

Removes extra nfs: field in the persistentVolume object when EFS enabled.

Older Helm versions seem to have just ignored this, but latest Helm does not.

Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Updated Helm chart version to 3.6.10
    • Modified persistent volume configuration for EFS-backed storage deployments

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7353fcba-4d1e-49c9-bb82-d99a8dc2b4fe

📥 Commits

Reviewing files that changed from the base of the PR and between cb24bb4 and 14e8551.

⛔ Files ignored due to path filters (1)
  • deploy/helm/tests/__snapshot__/defaults_snapshot_test.yaml.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • deploy/helm/Chart.yaml
  • deploy/helm/templates/persistentVolume.yaml
💤 Files with no reviewable changes (1)
  • deploy/helm/templates/persistentVolume.yaml

Walkthrough

This pull request bumps the Helm chart version from 3.6.9 to 3.6.10 and removes the NFS configuration block from the EFS-backed PersistentVolume CSI specification, retaining only the CSI driver and volumeHandle fields.

Changes

Cohort / File(s) Summary
Helm Chart Versioning
deploy/helm/Chart.yaml
Version bumped from 3.6.9 to 3.6.10.
PersistentVolume Configuration
deploy/helm/templates/persistentVolume.yaml
Removed the nfs: block under spec.csi for EFS-backed PersistentVolume; CSI driver and volumeHandle fields remain.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🎉 Chart ascends to 3.6.10's height,
NFS config removed—cleaner sight,
EFS reigns supreme with CSI might,
Version drift corrected, all feels right!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing an extra NFS field from the PersistentVolume object in the Helm template.
Description check ✅ Passed The description covers the main issue, explains the motivation (Helm version compatibility), includes the issue reference, and addresses all key template sections despite some boilerplate elements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ww-fix-helm-efs-template

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sebastianiv21 sebastianiv21 self-requested a review April 8, 2026 15:17
@github-actions github-actions bot added Bug Something isn't working Community Reported issues reported by community members Deploy Preview Issues found in Deploy Preview DevOps Pod Issues related to devops K8s Kubernetes related issues Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage labels Apr 8, 2026
@wyattwalter wyattwalter merged commit 306f25f into release Apr 8, 2026
17 checks passed
@wyattwalter wyattwalter deleted the ww-fix-helm-efs-template branch April 8, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Community Reported issues reported by community members Deploy Preview Issues found in Deploy Preview DevOps Pod Issues related to devops K8s Kubernetes related issues Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Helm chart broken for EKS high availability setup with EFS

2 participants