Add Analytics to Generate CRUD template feat#6503
Merged
rishabhrathod01 merged 3 commits intoreleasefrom Aug 10, 2021
Merged
Conversation
pranavkanade
previously approved these changes
Aug 10, 2021
rishabhsaxena
previously approved these changes
Aug 10, 2021
rishabhrathod01
dismissed stale reviews from rishabhsaxena and pranavkanade
via
064b706
Contributor
Author
Yes, added that just now. @rishabhsaxena can you review it. |
rishabhsaxena
previously approved these changes
Aug 10, 2021
pranavkanade
approved these changes
Aug 10, 2021
rishabhrathod01
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Add Analytics to Generate CRUD template feat * Add analytics event on datasource click * Send pluginName instead of plugin obj in analytics (cherry picked from commit 1827255)
ohansFavour
pushed a commit
that referenced
this pull request
Aug 12, 2021
* Add Analytics to Generate CRUD template feat * Add analytics event on datasource click * Send pluginName instead of plugin obj in analytics
ohansFavour
added a commit
that referenced
this pull request
Aug 13, 2021
* trimmed white spaces in datasource configuration * Added cypress tests for MySQLdatasource * fixed trailing whitespaces bug in mysql datasource configuration * Fix overflowing text in toasts on safari (#6200) * [Feature] Generate template page from datasource (#5513) - Add Generate CRUD page feature - Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit. - Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component. If `renderOption` prop is not defined, it will show default option UI. - Add getDatasourcesStructure [new entity Selector] ( This will provide all fetched structure of datasources) > Commit Messages ⬇️ * Show disabled GenPage Button for unsupported DS * Add Icon in Select Table and Column dropdown * Add Error message when datasource config has error * Fix the continous loading state issue * Add Not supported datasource in select Table * Add ignoreCache when fetching DS struct * Go to generate page if initiator=generate-page * Fix connect new datasource button disabled * Modify error message for invalid datasource struct * Add snowflake to supported plugin for template * Fix Show More option width * Fix incorrect error msg for valid dS config * Generate page UI improvements * Refactor navigation * Fix Datasource Card UX * Remove semi-colon from Icon loader * Refactor contants * Add executeDatasourceQuery & fetchPluginForm API - WIP google sheet form UI and functionality - Implemented fetch all spreadsheet with mock data * disable S3 and google sheet for generate page * Update yarn.lock * Resolve review comments - Add Messages to `constants/messages` - Add default value for `fetchActionsForPage` 2nd param - Add comment - Remove `onFinishCallback` from `handleFetchedPage` * move string literal to constants/messages * Remove hardcoded pluginId implementation * Refactor getGenerateCRUDEnabledPluginMap selector * Fix CreateAppInFirstListedOrg test command * Add getIsGeneratePageInitiator helper func * Fix Entity explorer Edit option test * Fix CreateAppForOrg test command - Add click on build from scratch in generatePage * Fix deleteDatasource command test - Click on Datasource Name to Edit, Datasource Card handles the click * Fix DynamicLayout spec test issue * Fix pageLoadSpec test * Disable google plugin & Refactor - Add useDatasourceOptions hook * Add datasourceCardMenu in DatasourceEditor.json * Fix issues - Add Icon hover clickable control - Auth API click handler * Fix Createpage test command * Add cypress test for generate page flow * Fix cypress test * Add Analytics * Add comments in CloseEditor * Rename initiator to isGeneratePageMode * Disable S3 for generate CRUD page * Fix generate page from existing datasource issue * Enhance test to verify if data is fetched properly * Wait for get Actions before execute actions * Change the cypress route for excute api Co-authored-by: Pranav Kanade <pranav@appsmith.com> * Fix xss redirectURL (#6229) * Update msg * Revert "Update msg" This reverts commit 0ac70ea. * Fix JS error message showing callstack in firefox (#6234) * Adding expiry of 30 days to session cookies (#6224) Fixes #5872 Adding an expiry of 30 days to the cookie to ensure that browsers don't delete the cookie when the browser session is closed. * Removing release-drafter github action (#6248) * Add Skip tour button in welcome onboarding (#6158) This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible. * Fix - #6221 new nav analytics improvements (#6223) * fixed redirection on connect data click. and updated analytics * Added generic analytics for all datasource cards * Add missed new nav analytics for connections (#6233) * Log event when property pane connected entity is clicked - Also update screen to source * Add missed analytic event when user navigates to entity from property pane connection - Also add entity type info to event - Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks * [Fix] Small UI improvements to suggested widgets section (#6190) * added slight transition to suggested widgets. Adjusted the height of arrows in relationship. * minor fixes to back btn style in suggested widgets panel * fixed the size of collapsible icon * removed a comment * Fix NPE when Segment key not available correctly (#6244) * Using local Postgres database instead of remote (#6241) * Using local Postgres database instead of remote * Added createdb and usedb at the top * FEATURE-5852 : make the iframe widget message property accessible (#5897) -- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget. * Disable tern in view mode (#6203) * Fixed ExecutionParams (#6284) * Fix test by mocking the response (#6273) * added cypress tests for users mock datasource * Fix: Mark comment threads as viewed when they are resolved (#6251) * -log widget type in analytics service when new thread created -set viewed=true for resolved threads * fixed typo * fix the test case when there is not widget type * Add analytics event for mock-data creation (#6136) * Add analytics event for mockdata creation * Use the correct name for the mockdatasource * Added FE analytics for mock datasource * Changes per review * Remove the method call * Fix indentation issue Co-authored-by: Pranav Kanade <pranav@appsmith.com> * Missing validations (#6281) * Fix validations for certain scenarios which were missed earlier * Minor comments feature fixes (#6245) * Fix comment card click: set visible thread (#6166) * Fixing bug where the comment feature flag was disabled for all users * [Fix] Refresh sidebar comments list when a thread is unresolved (#6326) * fix stop Rich text Editor from crashing on Modal (#6077) * changed RTE removal mechanism * modified changes to remove just before initializing * tinyMCE patch for firefox Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local> * Sentry typeError fix, with checks (#6256) Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local> * Supporting all ASCII characters in table widget (#6041) * Updated labels Mock data to Sample data (#6330) * [perf] propertyControl re-rendering (#5941) * prevent unnecessry re-renders on property control keyPress * Changes to memoize with useSelector * propertyControl re-rendering initial commit * Optimized and Generalized PropertyControl * Updating Property Dependencies * removing useCallback and replacing WidgetEnhancementHelpers with selector * nested property path changes * reverting name Change * tests fixes and adding dependencies for validation structure Co-authored-by: Satish Gandham <satish@appsmith.com> Co-authored-by: hetunandu <hetu@appsmith.com> Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local> * Snowflake get structure error resolved for columns query (#6316) * Table name reference copied from templates body to avoid misconfiguration in action body * more conditions for run check (#6255) Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local> * Fix comment card click at the view mode (#6332) * Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242) * Fix action creator unnecessary render issue - Optimize the selectors and hooks to return new values only when something has changed. * Fix ActionEntityContextMenu re-renders issue * Prevent rerenders of EntityName component * Fix CodeEditor re-renders * Use createSelector instead of memoization. * Cleanup * - Remove whyDidYouRender Co-authored-by: Satish Gandham <satish@appsmith.com> * Multiselect Widget (#5228) We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget. * Added instance Id in analytics datapoint (#6252) * Enable Autocomplete for Static Objects (#6302) * Remove type from COLORS constant * Remove type from InputTypes in InputWidget * Remove type from ReduxActionTypes * Remove type from ReduxErrorActionTypes * Remove type from SocialLoginTypes * Fix widget actions issues * Remove OPEN_SUB_PANE commented redux action * updated cypress tests to account for testing trailing spaces in db name and host address * removed unparsed token * Commenting test (#6354) * Add list buckets API to S3 (#6334) * Add list buckets action method to S3 * Added TC for list bucket method * FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337) reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished * Added null check to verify empty layout in generate CRUD page flow (#6359) * Fix authentication issue while creating mockdata (#6294) * Re set password to avoid double encryption while creating suffix datasource * Add test to query on mockdata source * Check the Authentication type before setting the password * updated cypress tests for mock datasource * fixed cypress failing datasources tests * Fix: Update debugger placeholder text for non-mac (#6142) * Added logic to show form data requests in debugger (#6350) * Added logic to show form data requests in debugger * Tests and comments * Tests * Tern server performance fix and Best match fix (#6338) * Uncomment Gen CRUD page Test (#6371) * Reorganised test steps to utilise retry action (#6208) * updated spec with assertion values (#6323) * updated spec with assert * updated test * updated test * updated dsl * Improvement: Add limit on password length in user signup (#6312) * -add max password validation in FE and password validation in BE for signup * -added unit test for password length limit * - set max password length to 48 - add password length check in reset password * -removed password limit check from login * Fix binding query for the nested data responses (#6372) * Fix binding query for the nested data responses * Fix formatting issues and add comments * Updated comments * remove code duplications * Fix: Keep inspect entity in sync with the widget selection in the entity explorer * docs: Updates event archive * Navigation Dropdown feedback Changes (#6119) Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local> * Feature: Add API to set and get concurrent app editors (#6292) * -add an API in RTS to store and retrieve currently online users of an application * -handled the case when edit app event received before user is authenticated * -updated authentication API in rts * close modal on cancel btn click (#6383) The cancel button in the modal will now by default have the close action configured. * Button and chart fixes (#6373) * Added new file button file and fixed the bugs in chart and button Added new file button file and fixed the bugs in chart and button * Fixed JS toggle for Button widget * changed border radius of multiselect widget to 0px (#6349) * open link inside text component in a new tab (#6205) * Fix loading test data for Cypress tests in CodeBuild * Change dropdown widget to select widget in Github labels for automation to work properly (#6386) * Updating k8s README to point to docs.appsmith.com * iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295) * FIX-5414 : iFrame - When the source url is removed message is be displayed within the component * BUG : Iframe widget: wrong placeholder `Title` (#6053) Rectified the wrong placeholder in the iframe widget title property. * Use feature flag api to enable/disable comments (#6322) * Check if comments are enabled for comment intro modal (#6395) * Fix ts error release (#6396) * updated common method (#6397) * Fix #5740 - Api actions are treated as queries (#6381) * updated active datasources pane carry proper cta to create new action * properly creating action names in either api/query context * added a new separate new api/query btn component * moved empty datasources warning to messages * fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403) * Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data (#6360) * Icon Button Widget (#5723) Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio. * [Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated (#6407) * fix: Font size fixed for consistency between select and multi-select widget (#6400) * Skip btn comment onboarding (#6331) * [Fix] Reset comment mode hotkey (#6401) * Welcome tour GIF and Close button fixes (#6309) * * Chaged New Query GIF * Added close button for welcome tour final page * Changed Run GIF * Sticky sidebar z-index change * Added testcases * Replaced hardcoded colors and text with constants * Fix: Set a default option in select widget while adding from suggested widgets (#6236) * Fix jest test for comments by overriding isCommentMode selector (#6027) * Fix download with URL issue (#6179) * Bump tar from 6.0.5 to 6.1.6 in /app/client (#6392) Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.6. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.0.5...v6.1.6) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update CRUD template For S3 page (#6426) Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com> * Cypress tests for commenting feature (#5505) * Minor fixes for comments on the modal widget (#6368) * Update permission check for determining a user with dev access for comments intro (#6431) * Prevent Entire Editor Header from re rendering (#6415) * Seperate save indicator without rerendering entire Editor Header * stop unnecessary update to Saved message every second * moving raw strings to messages Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local> * [Fix] Focus the comment thread when opened after dismissing (#6437) * Dont fetch feature flags if not logged in (#6444) * Update README.md Fixed a spelling mistake * Fix: Parse api body to be shown as an object in debugger if possible (#6249) * Fix: List Widget issues (#6226) * fix binding * fix multiple binding not working issue * use box shadow inset + fix gap issue * fix container z index issue * fix resize ux issue * update container height * allow selecting list widget only when the property pane is not visible * fix resize handle overflow issue * fix dot issue in current item structure + fix resize issue for template * fix select widget not workign inside list widget issue * remove unused keys * fix jest test * fix derived.js test * add undefiend check * add currentIndex for autocomplete * revert white color to transparent for list container * fix pagination wrong calculation * remove beta tag * fix issue with cypress test failing * fix issue with dropdown widget * fix the boolean value issue Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local> * [Bugfix] Empty object creation in published pages for application object fixed * Omnibar redesign (#6288) Omni bar would now have the categories navigation and documentation. * [skip_changelog] Form login disabled after user uses OAuth login method (#6425) Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> * changed default image to old value loading from cloudinary (#6467) * Feature: Show a list of realtime app editors (#6286) * Added support for showing realtime app editors * emitting an event only when socket is connected * added a tooltip to show username/email * using proper selector * using theme * created the separate component for listing editors * created a separate hook for app collab events * moved collab user type to /entities * moved user visible strings to message constants * Revert "moved user visible strings to message constants" This reverts commit 04ac18a. * made provision to reset the concurrent editors list * Enable auto-start after VM restart (#6428) * BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260) -- Add a overlaid div for iframe * Added fix for cmd + enter not running google sheets actions (#6446) * Fix-Catch invalid google recaptcha v3 key error (#6034) * Handle invalid google recaptcha v3 key * changed default divider color to light grey (#6335) * fixed issue where the resize cursor did not appear on the left hand side of the widget (#6380) * Add null check for the nested data structure (#6479) * Add null check for the nested data structure * Add unit test for the null nested data * Adding a max size of approximately 1 MB of data fetched using appsmith (#6491) * WIP Restrict fetch size * Adding a cut off of approximately 1 MB of data fetched in postgres plugin * Code cleanup * Minor cleanup * [Fix] Minor comments feature fixes (#6490) * Fix skip btn * update sorting for mentions list * Show server logs when create cypress user fails * [Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477) * Revert "Supporting all ASCII characters in table widget (#6041)" (#6429) This reverts commit 3ae1bd6. * Updated flaky test (#6486) * Updated flaky test * updated another test * Store MongoDB creds in separate file from install.sh (#6499) * Store MongoDB creds in separate file from install.sh * Move MongoDB credentials to docker.env * Add Analytics to Generate CRUD template feat (#6503) * Add Analytics to Generate CRUD template feat * Add analytics event on datasource click * Send pluginName instead of plugin obj in analytics * Fix: Adding checks before we check for disallowCopy (#6214) * Fix: Adding checks to before we check for disallowCopy * Adding checks for undo logic when a child delete is undone but the parent is already deleted. * restore widgets if they have their parent available. * reported bugs. * undo only when parent exists. * Hotfix Table Widget crashes when there is a cyclical dependency (#6505) * FIX #5254 : dropdown height fixed and made scrollable (#6170) * will widget pane if user moves away from canvas (#6516) * Fix: intercom triggers are not working properly (#6512) * initializing the intercom as soon as the help components are mounted. * removed log * Fix: Undo-Delete of Containers fix (#6510) * Encrypt attributes (#6508) * encrypt attributes * updated references to DOM targets for accessing the Mock User datasource * Fix/omnibar landing bug (#6513) * hide certificate string using dots on UI (#6533) * replace actual certificate string with '*' like it is done for hiding password on the UI. * Updated Template * fixed failing cypress tests Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com> Co-authored-by: Pranav Kanade <pranav@appsmith.com> Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com> Co-authored-by: Hetu Nandu <hetunandu@gmail.com> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com> Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com> Co-authored-by: Abhinav Jha <abhinav@appsmith.com> Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com> Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Arpit Mohan <arpit@appsmith.com> Co-authored-by: rahulramesha <71900764+rahulramesha@users.noreply.github.com> Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local> Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com> Co-authored-by: Satish Gandham <satish@appsmith.com> Co-authored-by: hetunandu <hetu@appsmith.com> Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com> Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com> Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com> Co-authored-by: Nidhi <nidhi@appsmith.com> Co-authored-by: Confidence Okoghenun <cokoghenun@gmail.com> Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com> Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com> Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com> Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com> Co-authored-by: abhishek nayak <nayak.abhishek@gmail.com> Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local> Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com> Co-authored-by: Nipun Agarwal <31271538+nipun1999@users.noreply.github.com> Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com> Co-authored-by: Trisha Anand <trisha@appsmith.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: Sumit Kumar <sumit@appsmith.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Analytics to generate a crud page feature.
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased