feat: Geolocation APIs on appsmith by hetunandu · Pull Request #9295 · appsmithorg/appsmith

hetunandu · 2021-11-23T07:30:37Z

Description

Expose Geolocation apis to appsmith app developers

Fixes #9207

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased

// Code coverage diff between base branch:release and head branch: feature/geolocaion-api

Status	File	% Stmts	% Branch	% Funcs	% Lines
🔴	total	55.06 (-0.07)	36.93 (-0.04)	33.91 (-0.02)	55.58 (-0.07)
✨ 🆕	app/client/src/actions/browserRequestActions.ts	75	100	0	66.67
🔴	app/client/src/components/editorComponents/ActionCreator/Fields.tsx	31.74 (-0.19)	22.03 (-0.13)	7.79 (0)	31.19 (-0.19)
🔴	app/client/src/components/editorComponents/ActionCreator/index.tsx	40.11 (-0.43)	6.72 (-0.12)	40 (0)	40 (-0.44)
🟢	app/client/src/constants/messages.ts	74.11 (0.15)	100 (0)	23.4 (0.44)	79.81 (0.09)
🔴	app/client/src/reducers/entityReducers/appReducer.ts	63.64 (-6.36)	100 (0)	33.33 (-6.67)	63.64 (-6.36)
🔴	app/client/src/sagas/ActionExecution/ActionExecutionSagas.ts	23 (-2.29)	2 (-0.27)	20 (0)	24.21 (-1.67)
✨ 🆕	app/client/src/sagas/ActionExecution/GetCurrentLocationSaga.ts	14.71	0	0	15.87
🟢	app/client/src/selectors/commentsSelectors.ts	85.25 (1.64)	64.71 (2.95)	73.33 (0)	90.59 (2.35)
🔴	app/client/src/utils/autocomplete/EntityDefinitions.ts	27.03 (-1.1)	0 (0)	14.29 (-2.38)	26.47 (-1.12)
🔴	app/client/src/workers/Actions.ts	70.07 (-5.54)	50 (-5)	70 (-10.65)	68.6 (-6.17)
🟢	app/client/src/workers/evaluationUtils.ts	57.46 (0.28)	56.33 (1.9)	62.26 (1.88)	55.19 (0.32)

github-actions · 2021-11-23T07:31:33Z

Unable to find test scripts. Please add necessary tests to the PR.

github-actions · 2021-11-23T07:31:44Z

Unable to find test scripts. Please add necessary tests to the PR.

github-actions · 2021-11-23T07:32:21Z

Unable to find test scripts. Please add necessary tests to the PR.

hetunandu · 2021-11-23T08:11:40Z

/ok-to-test sha=d99d133

github-actions · 2021-11-23T08:12:13Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1493827808.
Workflow: Appsmith External Integration Test Workflow.
Commit: d99d133.
PR: 9295.

app/client/src/sagas/ActionExecution/GetCurrentLocationSaga.ts

hetunandu · 2021-11-30T07:55:05Z

/ok-to-test sha=2fad65b

github-actions · 2021-11-30T08:05:23Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1519808407.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2fad65b.
PR: 9295.

app/client/src/components/editorComponents/ActionCreator/index.tsx

….tsx Co-authored-by: Anand Srinivasan <66776129+eco-monk@users.noreply.github.com>

github-actions · 2021-11-30T10:38:09Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1519808407.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2fad65b.
PR: 9295.

…rg/appsmith into feature/geolocaion-api

hetunandu · 2021-12-07T05:54:56Z

/ok-to-test sha=d36c9ce

github-actions · 2021-12-07T05:55:32Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1548081116.
Workflow: Appsmith External Integration Test Workflow.
Commit: d36c9ce.
PR: 9295.

## Description **Revert Context -** Reverts #14890 (We had to revert the PR as we got some suggestions on improving the feature - now reverting the revert so we can have this feature out with improvements) **PR Context -** This pull request exposes window.postMessage() as a global function in the Appsmith platform. Post message safely enables cross-origin communication between window objects. Example use-case - Appsmith page embedded within an iframe which communicates with the container website Diagram for all the different levels of communication - ![Untitled-2022-09-12-1205](https://user-images.githubusercontent.com/10229595/189592030-98bc29ac-b94e-4c75-8567-965757cc0d18.png) **More on post message here** - https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage **References used for this PR:** 1. Geolocation APIs - #9295 2. setInterval and clearInterval support - #8158 **Fixes** #7241 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? Test plan - **Manual**: Created an app with different buttons holding different types of data and embedded it in a code sandbox within an iframe. Also removed the target origin which throws an error (App link - https://dev.appsmith.com/app/post-msg-app/page1-624c1af4d8e632741017682e, Codesandbox link - https://codesandbox.io/s/compassionate-tdd-6dnzzd?file=/src/index.js) - Added Jest tests - https://github.com/appsmithorg/TestSmith/issues/1892 - https://github.com/appsmithorg/TestSmith/issues/2068 - https://github.com/appsmithorg/TestSmith/issues/2069 - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>

Geolocation apis on appsmith

0e91208

hetunandu changed the title ~~Geolocation apis on appsmith~~ Geolocation APIs on appsmith Nov 23, 2021

hetunandu changed the title ~~Geolocation APIs on appsmith~~ feat: Geolocation APIs on appsmith Nov 23, 2021

hetunandu requested review from eco-monk, ohansFavour and rishabhrathod01 November 23, 2021 07:31

github-actions bot added the Enhancement New feature or request label Nov 23, 2021

hetunandu mentioned this pull request Nov 23, 2021

docs: geolocation api appsmithorg/appsmith-docs#300

Merged

Update tests

d99d133

eco-monk reviewed Nov 25, 2021

View reviewed changes

app/client/src/sagas/ActionExecution/GetCurrentLocationSaga.ts Show resolved Hide resolved

hetunandu added 2 commits November 30, 2021 12:46

Add to action creator

ef02739

Improvements

5276118

hetunandu requested a review from eco-monk November 30, 2021 07:28

Correct names

2fad65b

eco-monk reviewed Nov 30, 2021

View reviewed changes

app/client/src/components/editorComponents/ActionCreator/index.tsx Outdated Show resolved Hide resolved

Update app/client/src/components/editorComponents/ActionCreator/index…

023a479

….tsx Co-authored-by: Anand Srinivasan <66776129+eco-monk@users.noreply.github.com>

eco-monk previously approved these changes Nov 30, 2021

View reviewed changes

mohanarpit and others added 3 commits December 3, 2021 13:45

Merge branch 'release' into feature/geolocaion-api

735a417

Allow for callbacks in watch location

41010c8

Merge branch 'feature/geolocaion-api' of https://github.com/appsmitho…

d36c9ce

…rg/appsmith into feature/geolocaion-api

hetunandu dismissed eco-monk’s stale review via d36c9ce December 6, 2021 08:56

hetunandu requested a review from eco-monk December 6, 2021 09:12

eco-monk previously approved these changes Dec 7, 2021

View reviewed changes

Merge branch 'release' into feature/geolocaion-api

7fbb285

hetunandu dismissed eco-monk’s stale review via 7fbb285 December 7, 2021 09:48

hetunandu merged commit 7143bba into release Dec 7, 2021

hetunandu deleted the feature/geolocaion-api branch December 7, 2021 10:19

Nikhil-Nandagopal added Test and removed Test labels Dec 29, 2021

rimildeyjsr mentioned this pull request Apr 14, 2022

feat: Add a field for the post message api exposure #12551

Merged

7 tasks

rimildeyjsr mentioned this pull request Jun 30, 2022

feat: Expose window.postMessage as a global function #14923

Closed

7 tasks

rimildeyjsr mentioned this pull request Sep 5, 2022

feat: Add postMessage as a global function #14925

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Geolocation APIs on appsmith#9295

feat: Geolocation APIs on appsmith#9295
hetunandu merged 10 commits intoreleasefrom
feature/geolocaion-api

hetunandu commented Nov 23, 2021 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

hetunandu commented Nov 23, 2021

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

Uh oh!

hetunandu commented Nov 30, 2021

Uh oh!

github-actions bot commented Nov 30, 2021

Uh oh!

Uh oh!

github-actions bot commented Nov 30, 2021

Uh oh!

hetunandu commented Dec 7, 2021

Uh oh!

github-actions bot commented Dec 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hetunandu commented Nov 23, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Test coverage results 🧪

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

hetunandu commented Nov 23, 2021

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

Uh oh!

hetunandu commented Nov 30, 2021

Uh oh!

github-actions bot commented Nov 30, 2021

Uh oh!

Uh oh!

github-actions bot commented Nov 30, 2021

Uh oh!

hetunandu commented Dec 7, 2021

Uh oh!

github-actions bot commented Dec 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hetunandu commented Nov 23, 2021 •

edited by github-actions bot

Loading