Conversation
# Conflicts: # ios_device/servers/dvt.py # ios_device/util/dtx_msg.py
fix：get FPS AttributeError: 'DTXMessage' object has no attribute 'plist'
fix start get fps AttributeError: 'DTXMessage' object has no attribute 'plist'
添加日志级别 Error 的设置
update dev branch
fbaptista
changed the title
franpandol
reviewed
Oct 5, 2021
Co-authored-by: franpandol <pandol.francisco@gmail.com>
|
Solo vi dos cosas un toque raras, primero que hay variables en mayúscula, no es un error de sintaxis pero es raro en python Kperf = KperfData(rpc) y lo otro que es justo en el mismo lugar, es que esa variable se declara después de un método interno que la usa. Creo que en runtime no debería dar problemas, me pareció un toque extraño pero no se si está hecho asi a propósito. |
juanibonini
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing using
devbranch on Windows & iOS 15.1https://staging-report.apptim.com/public/8a7b67a7-a6d4-11ea-b1c0-1-23424692-f219-4569-beaa-009e0911d86e/report/report/index.html