-
Notifications
You must be signed in to change notification settings - Fork 0
Add JSON log parsing #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Depends on #14 |
simu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good.
Does this also affect logs which are ingested into the default cluster-logging Elasticsearch? That's not very clear from the documentation.
PS: why are there 15 commits in this PR?
|
Looking at the commits in more detail, it's probably because you used GitHub's "Update Branch" which just merges master into the feature branch instead of rebasing the feature branch on the latest master. |
corvus-ch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the git history. Please rebase.
|
WTF... git, are you mad? |
d5f0900 to
2216429
Compare
2216429 to
967b3b8
Compare
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog