-
Notifications
You must be signed in to change notification settings - Fork 0
Add prometheus rules #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
02abcf3 to
a1cdc14
Compare
28acf17 to
16fd07b
Compare
simu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, with one big caveat: we lose the functionality of adding custom annotations to openshift-logging alerts and removing individual openshift-logging alerts via parameters.openshift4_monitoring.alerts with this change.
See https://github.com/projectsyn/component-rook-ceph/blob/master/component/alertrules.libsonnet for an example which implements custom annotations and removal of rules. The idea there was that we'd move the core logic for adding custom annotations and removing rules based on the contents of parameters.openshift4_monitoring.alerts to a component library in component openshift4-monitoring, once more components start having a need to make their alert rules ready for OCP4.
16fd07b to
0d4ea16
Compare
Move prometheus rules from openshift4-monitoring component to logging component.
0d4ea16 to
a56b319
Compare
simu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see inline comments for some cleanup and a note regarding recording rules.
| // only create duplicates of alert rules, we can use the recording | ||
| // rules which are deployed anyway when we enable monitoring on the | ||
| // CephCluster resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment is just copy-pasted. We should check if the recording rules (if there are any) are actually deployed by the cluster-logging operator, and adjust the filter function if we need to deploy the recording rules ourselves.
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Move prometheus rules from openshift4-monitoring component to logging component.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog