Expose cluster-logging version in parameter version
#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/set-clusterlogging-collection-type
branch
from
560f061 to
b3524a8
Compare
simu
force-pushed
the
feat/param-version
branch
4 times, most recently
from
f4de671 to
7aa32df
Compare
We introduce a new parameter `version` which is used to define default values for parameters `channel` and `alerts`. This change is backwards-compatible, as users can still override parameters `channel` and `alerts`. Because this removes the commit ID based setup for fetching the alert rules YAML, we also remove the renovate regex manager config to automatically generate PRs for new alert commit IDs.
simu
force-pushed
the
feat/param-version
branch
from
7aa32df to
834f103
Compare
simu
changed the base branch from
fix/set-clusterlogging-collection-type
to
master
simu
force-pushed
the
feat/param-version
branch
from
834f103 to
2f8356a
Compare
bastjan
approved these changes
Nov 11, 2022
Member
bastjan
left a comment
bastjan
left a comment
There was a problem hiding this comment.
LGTM
Maybe the docs could be clearer if users are expected to override versions and what versions are tested.
Member
Author
Any specific sections which you think could be clearer? There'll be more details in the documentation in the follow-up PRs which add support for 5.5 |
Member
|
The A link to the additional docs would be sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a new parameter
versionwhich is used to define default values for parameterschannelandalerts. This change is backwards-compatible, as users can still override parameterschannelandalerts.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.