Refactor queue publishers#12288
Open
ChiragAgg5k wants to merge 7 commits into
Open
Conversation
✨ Benchmark resultsComparing 1.9.x (before) to chore/queue-publisher-migration (after). Before
After
Delta
Top API waits
|
🔄 PHP-Retry SummaryFlaky tests detected across commits: Commit
|
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testFunctionsStats |
1 | 10.23s | Logs |
UsageTest::testPrepareSitesStats |
1 | 7ms | Logs |
UsageTest::testEmbeddingsTextUsageDoesNotBreakProjectUsage |
1 | 5ms | Logs |
MigrationsConsoleClientTest::testAppwriteMigrationOverwriteAttributeRecreateDropsAndRecreates |
1 | 12.96s | Logs |
MigrationsConsoleClientTest::testAppwriteMigrationOverwriteSameSpecRecreateTolerates |
1 | 60.37s | Logs |
Commit 848ef59 - 28 flaky tests
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testFunctionsStats |
1 | 10.16s | Logs |
UsageTest::testPrepareSitesStats |
1 | 6ms | Logs |
UsageTest::testEmbeddingsTextUsageDoesNotBreakProjectUsage |
1 | 5ms | Logs |
WebhooksCustomServerTest::testDeleteDeployment |
1 | 36ms | Logs |
WebhooksCustomServerTest::testDeleteFunction |
1 | 11ms | Logs |
WebhooksCustomServerTest::testCreateCollection |
1 | 9ms | Logs |
WebhooksCustomServerTest::testCreateAttributes |
1 | 11ms | Logs |
WebhooksCustomServerTest::testCreateDocument |
1 | 73ms | Logs |
WebhooksCustomServerTest::testUpdateDocument |
1 | 9ms | Logs |
WebhooksCustomServerTest::testDeleteDocument |
1 | 11ms | Logs |
WebhooksCustomServerTest::testCreateTable |
1 | 11ms | Logs |
WebhooksCustomServerTest::testCreateColumns |
1 | 13ms | Logs |
WebhooksCustomServerTest::testCreateRow |
1 | 9ms | Logs |
WebhooksCustomServerTest::testUpdateRow |
1 | 12ms | Logs |
WebhooksCustomServerTest::testDeleteRow |
1 | 11ms | Logs |
WebhooksCustomServerTest::testCreateStorageBucket |
1 | 7ms | Logs |
WebhooksCustomServerTest::testUpdateStorageBucket |
1 | 12ms | Logs |
WebhooksCustomServerTest::testCreateBucketFile |
1 | 12ms | Logs |
WebhooksCustomServerTest::testUpdateBucketFile |
1 | 6ms | Logs |
WebhooksCustomServerTest::testDeleteBucketFile |
1 | 6ms | Logs |
WebhooksCustomServerTest::testDeleteStorageBucket |
1 | 25ms | Logs |
WebhooksCustomServerTest::testCreateTeam |
1 | 10ms | Logs |
WebhooksCustomServerTest::testUpdateTeam |
1 | 20ms | Logs |
WebhooksCustomServerTest::testUpdateTeamPrefs |
1 | 12ms | Logs |
WebhooksCustomServerTest::testDeleteTeam |
1 | 5ms | Logs |
WebhooksCustomServerTest::testCreateTeamMembership |
1 | 13ms | Logs |
WebhooksCustomServerTest::testDeleteTeamMembership |
1 | 9ms | Logs |
WebhooksCustomServerTest::testWebhookAutoDisable |
1 | 29ms | Logs |
Commit 7401442 - 4 flaky tests
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testFunctionsStats |
1 | 10.18s | Logs |
UsageTest::testPrepareSitesStats |
1 | 7ms | Logs |
UsageTest::testEmbeddingsTextUsageDoesNotBreakProjectUsage |
1 | 5ms | Logs |
LegacyCustomServerTest::testUpdateWithExistingRelationships |
1 | 241.43s | Logs |
Commit bdc7cf3 - 5 flaky tests
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testFunctionsStats |
1 | 10.24s | Logs |
UsageTest::testPrepareSitesStats |
1 | 7ms | Logs |
UsageTest::testEmbeddingsTextUsageDoesNotBreakProjectUsage |
1 | 5ms | Logs |
TablesDBConsoleClientTest::testListDocumentsCachePurgedByUpdate |
1 | 3.11s | Logs |
TablesDBConsoleClientTest::testEnforceCollectionPermissions |
1 | 240.36s | Logs |
Commit a8f08da - 6 flaky tests
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testFunctionsStats |
1 | 10.20s | Logs |
UsageTest::testPrepareSitesStats |
1 | 7ms | Logs |
UsageTest::testEmbeddingsTextUsageDoesNotBreakProjectUsage |
1 | 5ms | Logs |
LegacyConsoleClientTest::testUpsertDocument |
1 | 240.58s | Logs |
LegacyCustomClientTest::testOneToManyRelationship |
1 | 240.19s | Logs |
LegacyCustomServerTest::testOneToManyRelationship |
1 | 240.19s | Logs |
Note: Flaky test results are tracked for the last 5 commits
…r-migration # Conflicts: # app/init/resources/request.php
# Conflicts: # composer.lock
# Conflicts: # src/Appwrite/Platform/Tasks/ScheduleFunctions.php # src/Appwrite/Platform/Workers/Functions.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queueFor*services topublisherFor*services.Tests
vendor/bin/phpunit tests/unit/Event/QueuePublisherTest.phpgit diff --name-only origin/1.9.x...HEAD -- '*.php' | xargs -n 1 php -lgit diff --check origin/1.9.x...HEAD