Skip to content

Feat: Refactored SSL genration#3074

Merged
TorstenDittmann merged 12 commits into0.14.xfrom
feat-certificate-refactor
May 11, 2022
Merged

Feat: Refactored SSL genration#3074
TorstenDittmann merged 12 commits into0.14.xfrom
feat-certificate-refactor

Conversation

@Meldiron
Copy link
Copy Markdown
Contributor

@Meldiron Meldiron commented Apr 10, 2022

What does this PR do?

a LOT!

  • Renew is now properly controlled by maintenance cycle instead of relying on Redis
  • We now double-check renew date with certificate file
  • We now properly retry certificate generation
  • We now properly respect 'attempts' limit
  • SSL command now runs without 30 seconds delay
  • SSL command now accepts optional attribute for domain that needs to be renewed
  • SSL command skips renew date validation
  • If issue fails, we schedule a job to send email to administrator

Test Plan

  • Manual QA (we probably need more)

Related PRs and Issues

Issues:

PRs:

Have you read the Contributing Guidelines on issues?

Yes

@Meldiron Meldiron changed the base branch from master to 0.14.x May 11, 2022 14:09
@TorstenDittmann TorstenDittmann merged commit 83702bf into 0.14.x May 11, 2022
@TorstenDittmann TorstenDittmann deleted the feat-certificate-refactor branch May 11, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants