Skip to content

fix : Linode file upload failure#3732

Closed
everly-gif wants to merge 2 commits intomasterfrom
fix-linode-file-upload
Closed

fix : Linode file upload failure#3732
everly-gif wants to merge 2 commits intomasterfrom
fix-linode-file-upload

Conversation

@everly-gif
Copy link
Copy Markdown
Contributor

@everly-gif everly-gif commented Aug 29, 2022

What does this PR do?

Fixes Linode File upload. It initially was failing because of the extra / in the request url.
It was making a request to a URL as below, which is invalid because of the consecutive //

https://<bucket-name>.eu-central-1.linodeobjects.com**//**storage/uploads/app-630cd8d7a106aa302d27/630cd8e90d3b33e8ff5c/6/3/0/c/630cdc2875416374d993.jpg

and hence failing.

Now, we trim the path string before uploading to remove the leading extra slash for providers such as Backblaze, Linode and Wasabi as they all require the removal.

Test Plan

  • Manual


Related PRs and Issues

#3433

Have you read the Contributing Guidelines on issues?

Yes

@everly-gif everly-gif requested a review from eldadfux August 29, 2022 16:43
Copy link
Copy Markdown
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there's must be a more strategic place to have this check. @lohanidamodar @christyjacob4 any ideas?

@lohanidamodar
Copy link
Copy Markdown
Member

@eldadfux
Copy link
Copy Markdown
Member

eldadfux commented Sep 8, 2022

Yeh, I think that can work. cc @everly-gif

@everly-gif
Copy link
Copy Markdown
Contributor Author

Yeh, I think that can work. cc @everly-gif

sure , Ill make the changes there

@everly-gif
Copy link
Copy Markdown
Contributor Author

Closing this PR in favour of #54.

@everly-gif everly-gif closed this Oct 18, 2022
@TorstenDittmann TorstenDittmann deleted the fix-linode-file-upload branch September 10, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants