Closed
Conversation
eldadfux
requested changes
Aug 29, 2022
Member
eldadfux
left a comment
There was a problem hiding this comment.
I feel like there's must be a more strategic place to have this check. @lohanidamodar @christyjacob4 any ideas?
Member
|
@eldadfux may be we can do the trim in the device constructor? |
Member
|
Yeh, I think that can work. cc @everly-gif |
Contributor
Author
sure , Ill make the changes there |
Contributor
Author
|
Closing this PR in favour of #54. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Linode File upload. It initially was failing because of the extra
/in the request url.It was making a request to a URL as below, which is invalid because of the consecutive
//and hence failing.
Now, we trim the path string before uploading to remove the leading extra slash for providers such as Backblaze, Linode and Wasabi as they all require the removal.
Test Plan
Related PRs and Issues
#3433
Have you read the Contributing Guidelines on issues?
Yes