Skip to content

Fix: SMS mock e2e tests#3879

Merged
christyjacob4 merged 2 commits into0.16.xfrom
feat-improve-sms-e2e-tests
Sep 23, 2022
Merged

Fix: SMS mock e2e tests#3879
christyjacob4 merged 2 commits into0.16.xfrom
feat-improve-sms-e2e-tests

Conversation

@Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Sep 19, 2022

What does this PR do?

Improve e2e SMS mock tests. They now:

  • Test user & password
  • Generate random secrets
  • Test worker (by sending real request to request catcher)

Test Plan

  • New tests implemented

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes 💪

@Meldiron Meldiron mentioned this pull request Sep 19, 2022
@christyjacob4 christyjacob4 changed the base branch from master to 0.16.x September 23, 2022 06:13
@christyjacob4 christyjacob4 merged commit 44cc332 into 0.16.x Sep 23, 2022
@stnguyen90 stnguyen90 deleted the feat-improve-sms-e2e-tests branch February 14, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants