Skip to content

Add retention env vars to deletes worker#8662

Merged
christyjacob4 merged 1 commit into1.6.xfrom
fix-retention
Sep 17, 2024
Merged

Add retention env vars to deletes worker#8662
christyjacob4 merged 1 commit into1.6.xfrom
fix-retention

Conversation

@stnguyen90
Copy link
Copy Markdown
Contributor

What does this PR do?

The resources are injected in the deletes worker so the env vars need to be passed to the container.

Test Plan

Manually worked with a user to update their docker-compose.yml file

Related PRs and Issues

None

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

The resources are injected in the deletes worker so the env vars need to be passed to the container.
@github-actions
Copy link
Copy Markdown

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
pyc 3.11.9-r0 CVE-2024-6232 HIGH
pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3 3.11.9-r0 CVE-2024-6232 HIGH
python3 3.11.9-r0 CVE-2024-7592 HIGH
python3-pyc 3.11.9-r0 CVE-2024-6232 HIGH
python3-pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-6232 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-7592 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

✨ Benchmark results

  • Requests per second: 1,432
  • Requests with 200 status code: 257,872
  • P99 latency: 0.091293362

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,432 1,551
200 257,872 279,137
P99 0.091293362 0.090415473

@stnguyen90 stnguyen90 marked this pull request as ready for review September 13, 2024 14:57
@stnguyen90 stnguyen90 self-assigned this Sep 13, 2024
@christyjacob4 christyjacob4 merged commit b591eac into 1.6.x Sep 17, 2024
@christyjacob4 christyjacob4 deleted the fix-retention branch September 17, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants