Fix migrations modal not closing #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We should be using a bound show variable to control the modal. Prior to this PR, we were indirectly controlling the modal by setting the migration ID via the on close handler, but that event is never triggered when the modal is closed. This also refactors the modal to pass in the migration instead of a list of migrations and a migration ID because the entire list is not needed inside the modal.
stnguyen90
force-pushed
the
fix-1025-close-migration-modal
branch
from
7b27455 to
7049f66
Compare
stnguyen90
changed the title
TorstenDittmann
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We should be using a bound show variable to control the modal. Prior to this PR, we were indirectly controlling the modal by setting the migration ID, but that isn't reliable due to how some of the variables are updated.
This also refactors the modal to pass in the migration instead of a list of migrations and a migration ID because the entire list is not needed inside the modal.
Fixes: #1025
Test Plan
Manual
Screen.Recording.2024-04-29.at.2.44.48.PM.mov
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
(Write your answer here.)