Skip to content

Chore: Upgrade Consoel SDK#1649

Merged
TorstenDittmann merged 1 commit intofeat-pink-v2from
fix-sites-sdk-changes
Feb 7, 2025
Merged

Chore: Upgrade Consoel SDK#1649
TorstenDittmann merged 1 commit intofeat-pink-v2from
fix-sites-sdk-changes

Conversation

@Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Feb 6, 2025

What does this PR do?

Updates console SDK to latest feat-sites API, and applies necessary fixes

Test Plan

Manual, fixed flows I noticed.

Related PRs and Issues

x

Have you read the Contributing Guidelines on issues?

x

await sdk.forProject.proxy.checkSubdomain(ResourceType.Site, value);
// TODO: @Meldiron Fix in future, blocked by issue PLA-2254
// await sdk.forProject.proxy.checkSubdomain(ResourceType.Site, value);
domainIsValid = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol :D

@TorstenDittmann TorstenDittmann merged commit 044528b into feat-pink-v2 Feb 7, 2025
3 of 5 checks passed
@TorstenDittmann TorstenDittmann deleted the fix-sites-sdk-changes branch February 7, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants