Skip to content

Conversation

lohanidamodar
Copy link
Member

What does this PR do?

  • Add route to view PDF invoice
  • Add route to download PDF invoice
  • Each route validates that invoice exists and then redirects to the REST endpoint

Test Plan

  • Manually tested it redirects to correct endpoint upon success
  • Manually tested it throws error if invoice doesn't exist

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

YES

Copy link
Member

@ItzNotABug ItzNotABug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already handle navigating to a different URL if the visitor doesn't have a session, right?

@lohanidamodar
Copy link
Member Author

we already handle navigating to a different URL if the visitor doesn't have a session, right?

Yes we do.

@lohanidamodar lohanidamodar merged commit 1f1e845 into main Feb 14, 2025
2 checks passed
@lohanidamodar lohanidamodar deleted the feat-invoice-view-download-url branch February 14, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants