Skip to content

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

The prefix should be the api endpoint instead of the base path so that the developer goes straight to the API endpoint to view or download their invoice.

Test Plan

Manually tested locally

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

The prefix should be the api endpoint instead of the base path so that
the developer goes straight to the API endpoint to view or download
their invoice.
@stnguyen90 stnguyen90 changed the title fix: fix invoice view and download links fix invoice view and download links May 27, 2025
@stnguyen90 stnguyen90 moved this to Code Review in 1.7 Release May 28, 2025
@stnguyen90 stnguyen90 requested a review from ItzNotABug May 28, 2025 00:32
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it uses endpoint based route, before we switched to console based routes (#1664), that will redirect to endpoint based routes. However it's already in console we can go either ways, your fix or mine
#1920

@stnguyen90
Copy link
Contributor Author

Since the user is already in the Console and has access to the invoice, I'd recommend using the api endpoint so we don't incur 2 additional network requests (one for the route and and one for the invoice lookup).

It makes sense to use the console route in the email in case they aren't logged into the Console from where they're opening the email.

@stnguyen90 stnguyen90 requested a review from lohanidamodar May 28, 2025 03:42
@ItzNotABug
Copy link
Member

Since the user is already in the Console and has access to the invoice, I'd recommend using the api endpoint so we don't incur 2 additional network requests (one for the route and and one for the invoice lookup).

It makes sense to use the console route in the email in case they aren't logged into the Console from where they're opening the email.

This makes more sense to me to hit the API directly. LGTM.

@ItzNotABug ItzNotABug merged commit 1d982f4 into main May 28, 2025
2 checks passed
@ItzNotABug ItzNotABug deleted the fix-invoice-view-download branch May 28, 2025 03:46
@github-project-automation github-project-automation bot moved this from Code Review to Done in 1.7 Release May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants