Fix flow for campaign credits apply #1795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItzNotABug
reviewed
Apr 15, 2025
ItzNotABug
approved these changes
Apr 15, 2025
ArmanNik
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added improved check for updating the billing plan. It now checks the plan order to prevent unwanted downgrades.
When applying the campaign results in the same plan the organisation is already on (or lower), the user will see this. And nothing will change in the plan of the organisation.
(screenshot shows a SCALE org with a PRO plan campaign)
When applying the campaign results in an upgrade, the user will be shown the campaign text in the estimated total box:
(screenshot shows a PRO org with a SCALE plan campaign)
Have you read the Contributing Guidelines on issues?
✅