Skip to content

Fix: title bug#2449

Merged
ItzNotABug merged 1 commit into
mainfrom
fix-dat-757
Oct 5, 2025
Merged

Fix: title bug#2449
ItzNotABug merged 1 commit into
mainfrom
fix-dat-757

Conversation

@ItzNotABug

@ItzNotABug ItzNotABug commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Svelte bug actually - @sveltejs/svelte/issues/14789

Test Plan

Manual.

Related PRs and Issues

https://discord.com/channels/564160730845151244/1420211316722892841

Have you read the Contributing Guidelines on issues?

Yes.

Summary by CodeRabbit

  • Bug Fixes
    • Resolved an issue where the Databases page header could persist incorrectly when navigating between pages. Headers now refresh reliably on path changes.
    • Ensured the browser title for database pages updates consistently during navigation (e.g., between different databases or projects), improving clarity and preventing stale titles.
    • Overall navigation within the Databases section now reflects the correct page state without lingering UI elements, with no changes to user workflows or functionality.

@ItzNotABug ItzNotABug self-assigned this Oct 5, 2025
@coderabbitai

coderabbitai Bot commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Two Svelte layout files under the databases routes were updated to wrap title elements in keyed blocks tied to page.url.pathname. In src/routes/(console)/project-[region]-[project]/databases/+layout.svelte, the page title is wrapped in a {#key page.url.pathname} block to force re-render on pathname changes. In src/routes/(console)/project-[region]-[project]/databases/database-[database]/+layout.svelte, the head title is similarly keyed. Comments note this addresses a Svelte rendering issue. No changes to exported/public entities or visible titles.

Suggested reviewers

  • HarshMN2345

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title “Fix: title bug” is related to the change but is too generic to clearly convey that the PR forces the page title to re-render on route changes via a Svelte {#key} workaround. It does not specify what aspect of the title is being fixed or reference the navigation/pathname issue. Consider renaming the PR to something more descriptive such as “Force page title re-render on route change” or “Fix page title not updating on navigation” to clearly capture the Svelte {#key} workaround and the pathname-triggered update.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-dat-757

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
src/routes/(console)/project-[region]-[project]/databases/+layout.svelte (1)

34-37: Effective workaround for the Svelte rendering bug.

The {#key} block correctly forces the title to re-render on pathname changes, addressing the issue where the page title persists incorrectly.

Optionally, consider making the comment more descriptive:

-    <!-- svelte bug, the table header just stays! -->
+    <!-- Workaround for Svelte bug #14789: forces title re-render on navigation -->

This improves clarity and provides a reference to the upstream issue for future maintainers.

src/routes/(console)/project-[region]-[project]/databases/database-[database]/+layout.svelte (1)

141-144: Effective workaround for the Svelte rendering bug.

The {#key} block correctly forces the title to re-render on pathname changes, addressing the issue where the page title persists incorrectly. Good consistency with the same workaround in the parent layout file.

Optionally, consider making the comment more descriptive (consistent with the suggestion for the parent layout):

-    <!-- svelte bug, the table header just stays! -->
+    <!-- Workaround for Svelte bug #14789: forces title re-render on navigation -->

This improves clarity and provides a reference to the upstream issue for future maintainers.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa1412d and cfcedad.

📒 Files selected for processing (2)
  • src/routes/(console)/project-[region]-[project]/databases/+layout.svelte (1 hunks)
  • src/routes/(console)/project-[region]-[project]/databases/database-[database]/+layout.svelte (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build

@ItzNotABug ItzNotABug merged commit fe3a404 into main Oct 5, 2025
3 checks passed
@ItzNotABug ItzNotABug deleted the fix-dat-757 branch October 5, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants