Skip to content

Conversation

@ItzNotABug
Copy link
Member

@ItzNotABug ItzNotABug commented Nov 6, 2025

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Bug Fixes

    • Project field in support wizard now requires a selection before form submission.
  • Chores

    • Updated internal dependencies to latest versions.

@ItzNotABug ItzNotABug self-assigned this Nov 6, 2025
@appwrite
Copy link

appwrite bot commented Nov 6, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Appwrite has a Discord community with over 16 000 members.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

Walkthrough

The pull request updates two dependencies in package.json to new version hashes and refactors form validation logic in the InputSelect component. The refactoring removes a top-level element reference and reactive validity block, replacing it with a locally-scoped element reference within the invalid event handler. Additionally, the required attribute is added to the project field in the support wizard form, making project selection mandatory.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • inputSelect.svelte refactoring: The removal of the reactive validity block and transition from a top-level HTMLSelectElement to a locally-scoped element reference in the event handler requires careful verification that validation behavior remains consistent, particularly around how custom validity is now set and checked.
  • Logic flow dependency: The supportWizard.svelte prop change depends on the validation refactoring in inputSelect.svelte functioning correctly; the interaction between these components should be verified.
  • Dependency updates: The package.json changes are straightforward but affect the components being modified, warranting verification that component functionality aligns with the updated dependencies.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main fix: input validation for select elements. It aligns with the core changes (updated validation logic in inputSelect.svelte and added required attribute in supportWizard.svelte).
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-dat-2141

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28d90a2 and ea560c1.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • package.json (1 hunks)
  • src/lib/elements/forms/inputSelect.svelte (1 hunks)
  • src/routes/(console)/supportWizard.svelte (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-26T06:48:57.938Z
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2373
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte:629-631
Timestamp: 2025-09-26T06:48:57.938Z
Learning: In the Appwrite console codebase using appwrite.io/pink-svelte, the Icon component automatically handles CSS variable names passed to its color prop by internally wrapping them with var(). Therefore, passing '--some-css-variable' as a string to the Icon color prop works correctly without needing to manually wrap it with var().

Applied to files:

  • package.json
📚 Learning: 2025-09-25T04:23:14.025Z
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2373
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/input.svelte:20-24
Timestamp: 2025-09-25T04:23:14.025Z
Learning: The Selector.Switch component from appwrite.io/pink-svelte doesn't accept `aria-describedby` or rest props (`...restProps`), limiting accessibility customization options.

Applied to files:

  • src/lib/elements/forms/inputSelect.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build
🔇 Additional comments (3)
package.json (1)

27-27: LGTM: Dependency updates.

The pink-svelte and pink-icons-svelte dependencies have been updated to a new version hash, which may include relevant fixes for the select validation improvements in this PR.

Also applies to: 29-29

src/routes/(console)/supportWizard.svelte (1)

128-128: LGTM: Project selection is now required.

Making the project field mandatory improves the quality of support requests by ensuring users specify which project they need help with.

src/lib/elements/forms/inputSelect.svelte (1)

42-44: LGTM: Error clearing logic is correct.

The reactive block appropriately clears the error message when a valid value is selected, providing good UX feedback.

@ItzNotABug ItzNotABug merged commit d0ff33c into main Nov 6, 2025
4 of 5 checks passed
@ItzNotABug ItzNotABug deleted the fix-dat-2141 branch November 6, 2025 06:52
@coderabbitai coderabbitai bot mentioned this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants