Skip to content

Conversation

@ItzNotABug
Copy link
Member

@ItzNotABug ItzNotABug commented Nov 13, 2025

What does this PR do?

Fixes #2596

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to latest versions for improved stability and compatibility.

@ItzNotABug ItzNotABug self-assigned this Nov 13, 2025
@appwrite
Copy link

appwrite bot commented Nov 13, 2025

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Git integration provides automatic deployments with optional PR comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Walkthrough

The pull request updates two dependency references in package.json: @appwrite.io/pink-icons-svelte and @appwrite.io/pink-svelte. Both dependencies have their Git commit references updated from 4472521 to bd82d9a. No other dependencies were modified, and no public-exported declarations were altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Dependency updates are limited to two packages with straightforward commit hash changes
  • No code logic modifications or structural changes
  • No public API or export alterations
  • Verify commit hashes bd82d9a and 4472521 correspond to expected versions of the Appwrite packages

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix: input selects' is vague and lacks specificity about what aspect of input selects is being fixed or how it relates to the dependency updates shown in the changeset. Clarify the title to better describe the specific issue being fixed, e.g., 'Fix: input select styling issues with updated pink dependencies' or provide more context about what functionality is being repaired.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-input-selects

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

27-27: Consider using semantic versioning or published releases instead of commit hashes.

Using git commit hashes as dependency versions is unconventional and reduces maintainability. Commit hashes are opaque to developers, harder to audit in changelogs, and increase friction during upgrades.

If bd82d9a represents a stable fix:

  • Check if the libraries have a published release/tag you can pin to instead
  • Otherwise, consider documenting why a commit hash is necessary (e.g., fix not yet released)
  • Ensure this is not a temporary pin that should be upgraded once a version is released

Based on learnings: The retrieved learning from PR #2567 mentions fixes related to Input.Select event handling in pink-svelte. Confirm that this update (bd82d9a) includes those fixes and any downstream code relying on HTMLInputElement type casting is compatible.

Also applies to: 29-29

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 372b110 and 39e9783.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2567
File: src/lib/elements/forms/inputSelect.svelte:26-36
Timestamp: 2025-11-06T06:47:24.645Z
Learning: In the appwrite.io/pink-svelte library, the Input.Select component internally uses an `input` element (not a `select` element) that triggers the `on:input` event, so event.target should be cast as HTMLInputElement in event handlers.
📚 Learning: 2025-09-26T06:48:57.938Z
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2373
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte:629-631
Timestamp: 2025-09-26T06:48:57.938Z
Learning: In the Appwrite console codebase using appwrite.io/pink-svelte, the Icon component automatically handles CSS variable names passed to its color prop by internally wrapping them with var(). Therefore, passing '--some-css-variable' as a string to the Icon color prop works correctly without needing to manually wrap it with var().

Applied to files:

  • package.json
🔇 Additional comments (1)
package.json (1)

27-27: Provide concrete PR description and clarify why commit hashes are used instead of semantic versions.

The packages @appwrite.io/pink-svelte (2.0.0-RC.2) and @appwrite.io/pink-icons-svelte (2.0.0-RC.1) publish to npm with semantic versioning, making the use of git commit hashes (4472521 → bd82d9a) via pkg.vc unusual and opaque.

The PR description is missing—it contains only placeholder template text. Please:

  1. Update the PR description to explain:
    • What specific problem exists with input selects
    • How commit bd82d9a addresses it
    • Any breaking changes or side effects
    • Why commit hashes are used instead of semantic versions or RC releases from npm
  2. Link to any related issues or previous PRs documenting the problem
  3. Clarify whether bd82d9a is temporary pre-release work or will become a published semantic version release

Also applies to: 29-29

@ItzNotABug ItzNotABug merged commit 3287d5b into main Nov 13, 2025
4 checks passed
@ItzNotABug ItzNotABug deleted the fix-input-selects branch November 13, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Functions > [function name] > Executions -> Create Executions no longer accepts the 'Now' setting

3 participants