Add: cache

[ItzNotABug]

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

• Chores
  • Optimized continuous integration pipeline with caching mechanisms to accelerate build times
  • Enhanced quality assurance with comprehensive testing, linting, and dependency auditing steps

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[appwrite]

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)

Site	Status	Logs	Preview	QR
console-stage 688b7cf6003b1842c9dc	Ready	View Logs	Preview URL

Tip

Schedule functions to run as often as every minute with cron expressions

[coderabbitai]

Walkthrough

The pull request modifies two GitHub Actions workflow files. The .github/workflows/e2e.yml changes introduce caching for Playwright browsers using a cache key based on the operating system and pnpm-lock.yaml hash, with a conditional step that skips browser installation on cache hits. The .github/workflows/tests.yml changes add a sequence of new CI steps including Node.js version 20 setup, pnpm configuration, dependency auditing, Svelte diagnostics, linting, unit testing, and a build step.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify the Playwright cache key construction is correct (OS and lock file hash combination)
• Confirm the conditional logic syntax for steps.playwright-cache.outputs.cache-hit is properly formatted YAML
• Validate all pnpm commands (audit, check, lint, test, build) are correctly spelled and available in the project
• Ensure Node.js version 20 is the intended target version for the test environment
• Confirm step ordering in the tests workflow is logical (e.g., audit-before-install timing)

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Add: cache' is vague and does not clearly convey what caching was added or why. It lacks specificity about the main change (e.g., caching Playwright browsers or CI dependencies).	Use a more descriptive title such as 'Cache Playwright browsers and dependencies in CI workflows' to better communicate the primary change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cach-ci-deps

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cbf8d2 and 523d3d7.

📒 Files selected for processing (2)

• .github/workflows/e2e.yml (1 hunks)
• .github/workflows/tests.yml (1 hunks)

🧰 Additional context used

🪛 actionlint (1.7.8)

.github/workflows/tests.yml

20-20: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

.github/workflows/e2e.yml

17-17: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🔇 Additional comments (3)

.github/workflows/e2e.yml (2)

27-38: Cache strategy is well-implemented.

The Playwright browser cache mechanism is configured correctly with:

• OS-aware cache key based on runner.os and pnpm-lock.yaml hash
• Fallback restore keys for partial cache hits
• Conditional browser installation that skips on cache hit
• Proper use of cache step output reference

This will significantly reduce build times on repeated runs.

---

43-43: Defensive artifact upload guard is good.

The if: ${{ !cancelled() }} condition ensures artifact collection even if tests are interrupted, improving visibility into partial failures. This is a solid practice.

.github/workflows/tests.yml (1)

27-43: Comprehensive CI gates with security-first audit.

The workflow now includes a well-ordered sequence of quality checks:

• Dependency audit as first step (security-conscious)
• Strict lockfile enforcement (reproducibility)
• Svelte diagnostics, linting, unit tests, and build (comprehensive coverage)

This represents a significant improvement to CI reliability and catch early failures. The audit step at line 28 with --audit-level high ensures high-severity vulnerabilities fail fast.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Update actions/setup-node to v4.

actions/setup-node@v3 is outdated and no longer actively maintained. Update to the latest version for improved compatibility, security patches, and performance.

Apply this diff:

  - name: Use Node.js
-   uses: actions/setup-node@v3
+   uses: actions/setup-node@v4
    with:
        node-version: 20

🧰 Tools

🪛 actionlint (1.7.8)

17-17: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents

In .github/workflows/e2e.yml around lines 17 to 19, update the GitHub Action
setup step to use the newer actions/setup-node@v4 instead of
actions/setup-node@v3; edit the workflow to change the action reference to
actions/setup-node@v4 while keeping the existing with: node-version: 20
configuration so the runner uses Node 20 with the maintained v4 action.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Update actions/setup-node to v4.

actions/setup-node@v3 is outdated and no longer actively maintained. Update to the latest version for improved compatibility, security patches, and performance.

Apply this diff:

  - name: Use Node.js
-   uses: actions/setup-node@v3
+   uses: actions/setup-node@v4
    with:
        node-version: 20

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	uses: actions/setup-node@v3
	with:
	node-version: 20
	uses: actions/setup-node@v4
	with:
	node-version: 20

🧰 Tools

🪛 actionlint (1.7.8)

20-20: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents

.github/workflows/tests.yml around lines 20 to 22: the workflow pins
actions/setup-node@v3 which is outdated; update the action reference to the
latest major (v4) by changing the uses entry to actions/setup-node@v4 so the
workflow uses the maintained version; ensure no other config keys break with v4
and run the workflow to verify node setup still works.