Skip to content

Conversation

@ItzNotABug
Copy link
Member

@ItzNotABug ItzNotABug commented Nov 30, 2025

What does this PR do?

Fixed via a bump to Pink.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Chores
    • Updated internal design system dependencies to the latest versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@appwrite
Copy link

appwrite bot commented Nov 30, 2025

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Each function runs in its own isolated container with custom environment variables

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 30, 2025

Walkthrough

This pull request updates two dependency references in package.json for Appwrite UI packages. The @appwrite.io/pink-icons-svelte package URL is updated from commit 6916470 to 865e2fc, and the @appwrite.io/pink-svelte package URL is similarly updated from commit 33845eb to 865e2fc. Both packages now reference the same commit hash.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that commit hash 865e2fc is valid and accessible across both package repositories
  • Confirm that aligning both packages to the same commit does not introduce dependency compatibility issues

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to fix tooltips not hiding on popovers, but the actual changes only update dependency URLs in package.json with no tooltip or popover-related code modifications. Update the title to accurately reflect the changes, such as 'Update Pink design system dependencies' or 'Bump @appwrite.io/pink-icons-svelte and @appwrite.io/pink-svelte dependencies'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-tooltips-popovers

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75d7523 and c1f0d2e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js,jsx,svelte,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use 4 spaces for indentation, single quotes, 100 character line width, and no trailing commas per Prettier configuration

Files:

  • package.json
🧠 Learnings (4)
📚 Learning: 2025-11-25T03:15:27.539Z
Learnt from: CR
Repo: appwrite/console PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T03:15:27.539Z
Learning: Applies to **/*.svelte : Use Svelte 5 + SvelteKit 2 syntax with TypeScript for component development

Applied to files:

  • package.json
📚 Learning: 2025-11-25T03:15:27.539Z
Learnt from: CR
Repo: appwrite/console PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T03:15:27.539Z
Learning: Applies to src/routes/**/*.svelte : Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Applied to files:

  • package.json
📚 Learning: 2025-11-25T03:15:27.539Z
Learnt from: CR
Repo: appwrite/console PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T03:15:27.539Z
Learning: Clear .svelte-kit directory and rebuild if code changes are not reflected in development server

Applied to files:

  • package.json
📚 Learning: 2025-09-26T06:48:57.938Z
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2373
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte:629-631
Timestamp: 2025-09-26T06:48:57.938Z
Learning: In the Appwrite console codebase using appwrite.io/pink-svelte, the Icon component automatically handles CSS variable names passed to its color prop by internally wrapping them with var(). Therefore, passing '--some-css-variable' as a string to the Icon color prop works correctly without needing to manually wrap it with var().

Applied to files:

  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build
🔇 Additional comments (2)
package.json (2)

27-27: Update the PR description to document the tooltip/popover fixes being applied.

The PR description is incomplete (showing only template placeholders). Add details about:

  • What specific tooltip/popover issues are fixed in commits 865e2fc (across both @appwrite.io/pink-icons-svelte and @appwrite.io/pink-svelte)?
  • What manual testing was performed?
  • Are there any breaking changes in these Pink UI commits?

Also consider including UI change screenshots in the PR description per your review guidelines.


27-27: Verify these git commit bumps contain the expected fixes.

Both Pink UI packages are pinned to the same commit hash (865e2fc). Before merging, confirm that:

  1. This commit actually contains the tooltip/popover fixes referenced in the PR
  2. The alignment to the same commit hash reflects an intentional monorepo release
  3. No breaking changes are introduced by these bumps

These verification steps require access to the external Pink UI repository and release documentation, which cannot be assessed from this repository alone.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ItzNotABug ItzNotABug changed the title Fixed via a bump to Pink Fix tooltips not hiding on popover's content view Nov 30, 2025
@ItzNotABug ItzNotABug self-assigned this Nov 30, 2025
@ItzNotABug ItzNotABug merged commit 0fa57b3 into main Nov 30, 2025
4 checks passed
@ItzNotABug ItzNotABug deleted the fix-tooltips-popovers branch November 30, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants