Skip to content

Change CNAME for functions custom domains#2863

Merged
hmacr merged 1 commit intomainfrom
ser-1115
Feb 17, 2026
Merged

Change CNAME for functions custom domains#2863
hmacr merged 1 commit intomainfrom
ser-1115

Conversation

@hmacr
Copy link
Contributor

@hmacr hmacr commented Feb 17, 2026

Towards SER-1115

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted CNAME tab availability in domain verification and retry workflows to use unified configuration logic for function domain management.

@appwrite
Copy link

appwrite bot commented Feb 17, 2026

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Functions can run for up to 15 minutes before timing out

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

This PR modifies domain target handling across three files within the functions domain management feature. In recordTable.svelte, the setTarget() function's 'cname' case branch is simplified by removing a specific APP_DOMAIN_FUNCTIONS return path for services, causing the code to fall through to APP_DOMAIN_TARGET_CNAME instead. In the verification and retry modal components, conditions that gate CNAME tab visibility are changed from checking _APP_DOMAIN_FUNCTIONS to _APP_DOMAIN_TARGET_CNAME. These changes unify the domain target variable usage across the functions domain management UI.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Change CNAME for functions custom domains' is clear, specific, and directly describes the main change: replacing the domain routing logic for CNAME records in function domain management, switching from APP_DOMAIN_FUNCTIONS to APP_DOMAIN_TARGET_CNAME.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ser-1115

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hmacr hmacr merged commit bff7bc0 into main Feb 17, 2026
9 checks passed
@hmacr hmacr deleted the ser-1115 branch February 17, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants