feat: build + runtime specification controls for sites and functions#2922
Merged
HarshMN2345 merged 8 commits intomainfrom Mar 20, 2026
Merged
feat: build + runtime specification controls for sites and functions#2922HarshMN2345 merged 8 commits intomainfrom
HarshMN2345 merged 8 commits intomainfrom
Conversation
Console (appwrite/console)Project ID: Tip HTTPS and SSL certificates are handled automatically for all your Sites |
Contributor
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis PR adds separate runtimeSpecification handling alongside buildSpecification for functions and sites: load handlers now validate and fallback runtimeSpecification to an enabled spec, component state and reactive bindings were extended to track buildSpecification and runtimeSpecification separately, and SDK update calls were extended to send runtimeSpecification. It also updates package.json (bumped Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Greptile SummaryThis PR adds independent build specification and runtime specification controls to the settings pages for both Functions and Sites, allowing users to configure CPU/memory independently for build-time and runtime workloads. It also migrates all webhook CRUD operations from the console-scoped SDK ( Key changes:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: "use enabledspecs" |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
.../(console)/project-[region]-[project]/sites/site-[site]/settings/updateResourceLimits.svelte
Show resolved
Hide resolved
...s/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte
Outdated
Show resolved
Hide resolved
ChiragAgg5k
approved these changes
Mar 20, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte (1)
114-120:⚠️ Potential issue | 🟡 MinorUse the enabled list for this fallback too.
This block falls back to
specs.specifications[0], not the first enabled spec. If the first entry is disabled, the sharedsiteobject can be rewritten to a slug that the resource-limits form and API should not use.Suggested fix
- if (specs && specs.specifications?.length) { - if (!specs.specifications.some((s) => s.slug === site.buildSpecification)) { - site.buildSpecification = specs.specifications[0].slug; - } - if (!specs.specifications.some((s) => s.slug === site.runtimeSpecification)) { - site.runtimeSpecification = specs.specifications[0].slug; - } + if (specs?.specifications?.length) { + const enabledSpecs = specs.specifications.filter((s) => s.enabled); + if (!enabledSpecs.some((s) => s.slug === site.buildSpecification)) { + site.buildSpecification = enabledSpecs[0]?.slug; + } + if (!enabledSpecs.some((s) => s.slug === site.runtimeSpecification)) { + site.runtimeSpecification = enabledSpecs[0]?.slug; + } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/routes/`(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte around lines 114 - 120, The fallback currently assigns specs.specifications[0] to site.buildSpecification and site.runtimeSpecification even if that spec is disabled; change the logic to pick the first enabled spec instead (e.g. find the first entry in specs.specifications where s.enabled is true) and use that slug as the fallback for both site.buildSpecification and site.runtimeSpecification so the site object never gets set to a disabled spec that the resource-limits form/API should ignore.src/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/updateResourceLimits.svelte (1)
34-74:⚠️ Potential issue | 🟡 MinorTelemetry still points at the logging action.
trackEventandtrackErrorstill emitSubmit.FunctionUpdateLogging, so resource-limit changes will be counted as logging updates.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/routes/`(console)/project-[region]-[project]/functions/function-[function]/settings/updateResourceLimits.svelte around lines 34 - 74, The telemetry calls in updateResourceLimits() are using the wrong event constant (Submit.FunctionUpdateLogging); change both trackEvent(...) and trackError(...) to the resource-limits-specific constant (e.g., Submit.FunctionUpdateResourceLimits) so telemetry reflects resource limit updates, ensuring you update the reference in both the success path and the catch block within updateResourceLimits().src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateResourceLimits.svelte (1)
33-68:⚠️ Potential issue | 🟡 MinorTelemetry is still tagged as a function logging update.
This handler now updates site resource limits, but
trackEvent/trackErrorstill useSubmit.FunctionUpdateLogging. These submissions will be misclassified in analytics and error dashboards.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/routes/`(console)/project-[region]-[project]/sites/site-[site]/settings/updateResourceLimits.svelte around lines 33 - 68, The telemetry calls in updateResourceLimits still reference Submit.FunctionUpdateLogging which mislabels this handler; update the tracking to use a meaningful constant like Submit.SiteResourceLimitsUpdate (or add that enum value if missing) and replace both trackEvent(Submit.FunctionUpdateLogging) and trackError(error, Submit.FunctionUpdateLogging) with trackEvent(Submit.SiteResourceLimitsUpdate) and trackError(error, Submit.SiteResourceLimitsUpdate) respectively so analytics and error dashboards reflect a site resource-limits update; ensure the new enum value is defined in the Submit enum where other submit types live.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@src/routes/`(console)/project-[region]-[project]/functions/function-[function]/settings/updateResourceLimits.svelte:
- Around line 34-74: The telemetry calls in updateResourceLimits() are using the
wrong event constant (Submit.FunctionUpdateLogging); change both trackEvent(...)
and trackError(...) to the resource-limits-specific constant (e.g.,
Submit.FunctionUpdateResourceLimits) so telemetry reflects resource limit
updates, ensuring you update the reference in both the success path and the
catch block within updateResourceLimits().
In
`@src/routes/`(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte:
- Around line 114-120: The fallback currently assigns specs.specifications[0] to
site.buildSpecification and site.runtimeSpecification even if that spec is
disabled; change the logic to pick the first enabled spec instead (e.g. find the
first entry in specs.specifications where s.enabled is true) and use that slug
as the fallback for both site.buildSpecification and site.runtimeSpecification
so the site object never gets set to a disabled spec that the resource-limits
form/API should ignore.
In
`@src/routes/`(console)/project-[region]-[project]/sites/site-[site]/settings/updateResourceLimits.svelte:
- Around line 33-68: The telemetry calls in updateResourceLimits still reference
Submit.FunctionUpdateLogging which mislabels this handler; update the tracking
to use a meaningful constant like Submit.SiteResourceLimitsUpdate (or add that
enum value if missing) and replace both trackEvent(Submit.FunctionUpdateLogging)
and trackError(error, Submit.FunctionUpdateLogging) with
trackEvent(Submit.SiteResourceLimitsUpdate) and trackError(error,
Submit.SiteResourceLimitsUpdate) respectively so analytics and error dashboards
reflect a site resource-limits update; ensure the new enum value is defined in
the Submit enum where other submit types live.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d163cc81-a914-4758-a286-e1665d03f12a
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
package.jsonsrc/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/+page.tssrc/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/updateResourceLimits.sveltesrc/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/+page.tssrc/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.sveltesrc/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateResourceLimits.svelte
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/routes/`(console)/project-[region]-[project]/settings/webhooks/[webhook]/delete.svelte:
- Line 17: The code calls sdk.forProject($project.region, $project.$id) which
can pass a nullable project region; replace the first argument with the route
param region (the route's params.region / local variable named region) when
scoping the SDK and validate it (or fall back explicitly) before calling
webhooks.delete; update the call in the function that invokes sdk.forProject
(referencing sdk.forProject, $project.$id and the route param region) so the SDK
is always scoped with the route param region rather than $project.region.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 387a92fc-7159-4152-be31-18ae1fb0e0cb
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (15)
package.jsonsrc/lib/stores/sdk.tssrc/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/updateResourceLimits.sveltesrc/routes/(console)/project-[region]-[project]/settings/webhooks/+page.tssrc/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/+layout.tssrc/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/delete.sveltesrc/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/details.sveltesrc/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/regenerate.sveltesrc/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/updateEvents.sveltesrc/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/updateName.sveltesrc/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/updateSecurity.sveltesrc/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/updateURL.sveltesrc/routes/(console)/project-[region]-[project]/settings/webhooks/create/+page.sveltesrc/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.sveltesrc/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateResourceLimits.svelte
🚧 Files skipped from review as they are similar to previous changes (3)
- src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte
- src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateResourceLimits.svelte
- src/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/updateResourceLimits.svelte
src/routes/(console)/project-[region]-[project]/settings/webhooks/[webhook]/delete.svelte
Outdated
Show resolved
Hide resolved
...s/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte
Outdated
Show resolved
Hide resolved
...s/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)
Summary by CodeRabbit
New Features
Bug Fixes
Chores