Skip to content

Fix row bulk delete freeze #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshMN2345 merged 2 commits into from
May 27, 2026
Merged

Fix row bulk delete freeze #3063

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
504d61b
Fix row bulk delete freeze
HarshMN2345 May 27, 2026
6d84c25
lint issue
HarshMN2345 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions ...project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,16 +427,23 @@
async function handleDelete() {
showDelete = false;
let hadErrors = false;
const rowIdsToDelete = selectedRowForDelete ? [selectedRowForDelete] : [...selectedRows];
const deletedRowsCount = rowIdsToDelete.length || 1;
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The || 1 fallback is now unreachable dead code. rowIdsToDelete is built as [selectedRowForDelete] or [...selectedRows], so when any deletion occurs its length is always ≥ 1. In the original code the fallback was needed because selectedRows.length was checked separately and could be 0 when only selectedRowForDelete was set — but that split no longer exists here.

Suggested change
const deletedRowsCount = rowIdsToDelete.length || 1;
const deletedRowsCount = rowIdsToDelete.length;


try {
if (selectedRowForDelete) {
$spreadsheetLoading = true;
selectedRows = [];
selectedRowForDelete = null;
spreadsheetRenderKey.set(hash(rowIdsToDelete));

if (rowIdsToDelete.length === 1) {
await sdk.forProject(page.params.region, page.params.project).tablesDB.deleteRow({
databaseId,
tableId,
rowId: selectedRowForDelete
rowId: rowIdsToDelete[0]
});
} else {
if (selectedRows.length) {
if (rowIdsToDelete.length) {
const hasAnyRelationships = table.fields.some(isRelationship) ?? false;

const tablesSDK = sdk.forProject(
Expand All @@ -445,7 +452,7 @@
).tablesDB;

if (hasAnyRelationships) {
for (const batch of chunks(selectedRows)) {
for (const batch of chunks(rowIdsToDelete)) {
try {
await Promise.all(
batch.map((rowId) =>
Expand All @@ -469,7 +476,7 @@
});
}
} else {
for (const batch of chunks(selectedRows, 100)) {
for (const batch of chunks(rowIdsToDelete, 100)) {
await tablesSDK.deleteRows({
databaseId,
tableId,
Expand All @@ -487,24 +494,19 @@
// error is already shown above!
addNotification({
type: 'success',
message: `${selectedRows.length ? selectedRows.length : 1} row${selectedRows.length > 1 ? 's' : ''} deleted`
message: `${deletedRowsCount} row${deletedRowsCount > 1 ? 's' : ''} deleted`
});
}

spreadsheetRenderKey.set(
hash([
data.rows.total.toString(),
...(selectedRows as string[]),
selectedRowForDelete
])
);
spreadsheetRenderKey.set(hash([data.rows.total.toString(), ...rowIdsToDelete]));
} catch (error) {
addNotification({ type: 'error', message: error.message });
trackError(error, Submit.RowDelete);
} finally {
selectedRows = [];
showDelete = false;
selectedRowForDelete = null;
$spreadsheetLoading = false;
}
}

Expand Down