Skip to content

Use enum and SDK methods #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 8, 2024
Merged

Use enum and SDK methods #771

merged 20 commits into from
Feb 8, 2024

Conversation

@stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Feb 6, 2024 •
edited
Loading

What does this PR do?

  • Use enums from the console SDK whenever possible
  • Remove unnecessary backup
  • Fix listInvoices() queries type
  • Add messaging service to sdkForProject
  • Replace client.call() with the respective SDK methods

Some svelte diagnostic checks still don't pass because of problems with the SDK.

Test Plan

Manual

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Feb 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 9:27am
console-preview 🛑 Canceled (Inspect) Feb 8, 2024 9:27am
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 9:27am

@stnguyen90
Copy link
Contributor Author

stnguyen90 commented Feb 6, 2024

@TorstenDittmann, sorry for the huge PR. The enum change was really big.

This was referenced Feb 7, 2024
Merged
Merged
abnegate
abnegate reviewed Feb 7, 2024
View reviewed changes
@stnguyen90 stnguyen90 requested a review from abnegate February 7, 2024 20:52
@stnguyen90 stnguyen90 mentioned this pull request Feb 7, 2024
Merged
@stnguyen90 stnguyen90 mentioned this pull request Feb 8, 2024
Merged
@TorstenDittmann
Merge pull request #774 from appwrite/feat-messaging-delete-messages
7bda700 
Add support for deleting messages
@TorstenDittmann
Merge pull request #779 from appwrite/feat-messaging-topics-targets-i…
213bb2b 
…n-message-details

Show messaging topics and targets in message details
@TorstenDittmann TorstenDittmann merged commit be09dde into 1.5.x Feb 8, 2024
@TorstenDittmann TorstenDittmann deleted the feat-messaging-sdk branch February 8, 2024 09:24
@stnguyen90 stnguyen90 mentioned this pull request Feb 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

@abnegate abnegate Awaiting requested review from abnegate

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stnguyen90 @abnegate @TorstenDittmann