Improve provider wizard #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
I think there's a unit test for the |
stnguyen90
force-pushed
the
fix-messaging-twilio-popover
branch
from
593e4f8 to
1d513ea
Compare
stnguyen90
force-pushed
the
fix-messaging-twilio-popover
branch
from
1d513ea to
ada49d7
Compare
1. Use class="link" for consistency 2. Add rel="noopener noreferrer" for consistency
Because of the input pattern uses the v RegExp flag, ranges like [A-Za-z] must be wrapped with []. In addition, the last - in [A-Za-z0-9-] needed to be escaped.
Having required will prevent submitting with value == false.
Skipping because these pass in the browser but fail in testing. It could be because of jsdom.
stnguyen90
force-pushed
the
fix-messaging-twilio-popover
branch
from
ada49d7 to
674c839
Compare
chenparnasa
reviewed
Feb 11, 2024
Contributor
chenparnasa
left a comment
chenparnasa
left a comment
There was a problem hiding this comment.
I left a comment on the linear issue
TorstenDittmann
approved these changes
Feb 13, 2024
The URLs should be generic console URLs without account/custom values.
chenparnasa
approved these changes
Feb 15, 2024
TorstenDittmann
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes appwrite/appwrite#5936
Test Plan
Manual
Related PRs and Issues
Child:
Have you read the Contributing Guidelines on issues?
Yes