fix: change maxUnavailable to 0 for zero-downtime deployments#10
Merged
ChiragAgg5k merged 1 commit intomainfrom Feb 16, 2026
Merged
fix: change maxUnavailable to 0 for zero-downtime deployments#10ChiragAgg5k merged 1 commit intomainfrom
ChiragAgg5k merged 1 commit intomainfrom
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis change modifies a Kubernetes Deployment configuration template by adjusting the rolling update strategy parameter. Specifically, the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes rolling deployment to ensure zero downtime by changing
maxUnavailablefrom 1 to 0.Problem
With
minReplicas: 1andmaxReplicas: 1, the current configuration allows the old pod to be terminated before the new pod is ready, causing downtime during deployments.Solution
Changed
maxUnavailableto 0 in the deployment strategy, ensuring the old pod remains running until the new pod passes readiness checks.Changes
deploy/mcp-for-docs/templates/mcp-for-docs.yaml: ChangedmaxUnavailable: 1tomaxUnavailable: 0Test Plan
Summary by CodeRabbit
Release Notes