feat: Command Line SDK update for version 20.0.0#305
Conversation
Greptile Summary
Confidence Score: 4/5Safe to merge after verifying the One P1 concern: lib/commands/push.ts — the Important Files Changed
Reviews (4): Last reviewed commit: "chore: update Command Line SDK to 20.0.0" | Re-trigger Greptile |
| .min(1, "Include path cannot be empty") | ||
| .refine((value) => !value.includes("\0"), { | ||
| message: "Include path cannot contain null bytes", | ||
| }) |
There was a problem hiding this comment.
Do we need multiple .refine() calls here? Since all these checks operate on the same value, this feels like a good candidate for a single superRefine.
| const response = await projectService.listMockPhones({ | ||
| queries: [Query.limit(limit), Query.offset(offset)], | ||
| }); | ||
|
|
||
| remoteMockNumbers.push(...response.mockNumbers); | ||
| total = response.total; | ||
| offset += response.mockNumbers.length; | ||
|
|
||
| if (response.mockNumbers.length === 0) { |
There was a problem hiding this comment.
Likely wrong property name on
listMockPhones response
The code accesses response.mockNumbers, but Appwrite's convention for list-response models is to name the array field after the plural of the resource type. Since the resource is MockPhone, the response model (MockPhoneList) almost certainly exposes a phones field, not mockNumbers. If the property name is wrong, response.mockNumbers is undefined, and spreading it on line 1064 immediately throws TypeError: undefined is not iterable, making the entire settings-push path fail for any project that has mock phone numbers configured. Can you confirm the exact property name on the listMockPhones response object? Based on Appwrite's SDK naming convention (e.g. FunctionList.functions, BucketList.buckets) this should be phones, not mockNumbers.
This PR contains updates to the Command Line SDK for version 20.0.0.