Skip to content

feat: support concurrent chunk uploads#320

Closed
TorstenDittmann wants to merge 1 commit into
masterfrom
concurrent-chunk-uploads-1-9-x-minimal
Closed

feat: support concurrent chunk uploads#320
TorstenDittmann wants to merge 1 commit into
masterfrom
concurrent-chunk-uploads-1-9-x-minimal

Conversation

@TorstenDittmann
Copy link
Copy Markdown
Contributor

This PR updates the SDK to support concurrent chunk uploads.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 21, 2026

Greptile Summary

This PR bumps the CLI version from 21.0.0 to 21.1.0 and registers three new service commands (presences, advisor, usage) in the Commander program. The version change is consistent across lib/constants.ts, package.json, and package-lock.json.

  • The source files for the three newly imported services (lib/commands/services/presences.ts, advisor.ts, usage.ts) are absent from the repository — the CLI will throw ERR_MODULE_NOT_FOUND on startup and be completely unusable until those files are added.
  • The PR title references "concurrent chunk uploads" but no upload-related logic appears in the diff; the description may belong to a different changeset or the implementation files were omitted.

Confidence Score: 1/5

Not safe to merge — the CLI entry point imports three module paths that do not exist, causing an immediate crash on any invocation.

The three new import statements in cli.ts reference .js modules (presences, advisor, usage) whose TypeScript source files are not present anywhere in the repository. Node's ESM resolver will throw ERR_MODULE_NOT_FOUND before the program can execute a single command, rendering the published CLI binary non-functional. The version bump and lockfile changes are fine in isolation, but they cannot ship without the missing service files.

cli.ts — the three new imports all point to missing files and will break the CLI at startup

Important Files Changed

Filename Overview
cli.ts Imports three new service modules (presences, advisor, usage) whose source files do not exist in the repository — the CLI will crash at startup with ERR_MODULE_NOT_FOUND
lib/constants.ts Version bumped from 21.0.0 to 21.1.0 — straightforward, consistent with package.json and package-lock.json
package.json Version bumped from 21.0.0 to 21.1.0 — consistent with lib/constants.ts and package-lock.json
package-lock.json Lockfile version updated to 21.1.0 in two places, matching package.json — no dependency changes

Reviews (1): Last reviewed commit: "feat: support concurrent chunk uploads" | Re-trigger Greptile

Comment thread cli.ts
Comment on lines +48 to +58
import { presences } from './lib/commands/services/presences.js';
import { project } from './lib/commands/services/project.js';
import { projects } from './lib/commands/services/projects.js';
import { proxy } from './lib/commands/services/proxy.js';
import { advisor } from './lib/commands/services/advisor.js';
import { sites } from './lib/commands/services/sites.js';
import { storage } from './lib/commands/services/storage.js';
import { tablesDB } from './lib/commands/services/tables-db.js';
import { teams } from './lib/commands/services/teams.js';
import { tokens } from './lib/commands/services/tokens.js';
import { usage } from './lib/commands/services/usage.js';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Missing source files for imported service modules

cli.ts imports presences, advisor, and usage from ./lib/commands/services/presences.js, ./lib/commands/services/advisor.js, and ./lib/commands/services/usage.js respectively, but none of those .ts source files exist in the repository. Node's ESM loader will throw an ERR_MODULE_NOT_FOUND error the moment any user invokes the CLI, making the entire binary non-functional on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants