feat: Node.js SDK update for version 24.0.0#148
Conversation
Greptile SummaryThis PR delivers the Node.js SDK update for Appwrite 24.0.0: breaking webhook field/method renames (
Confidence Score: 4/5Safe to merge after fixing the Webhook.secret type annotation; all other changes are mechanically correct. One P1 type-safety defect: Webhook.secret is declared as required string but is only conditionally present in API responses, creating a silent runtime/TypeScript mismatch. All other service implementations, enums, models, and CI changes look correct. src/models.ts — Webhook.secret field annotation Important Files Changed
Reviews (4): Last reviewed commit: "chore: update Node.js SDK to 24.0.0" | Re-trigger Greptile |
| "@types/json-bigint": "1.0.4", | ||
| "@types/node": "20.11.25", | ||
| "tsup": "7.2.0", | ||
| "tsup": "^8.5.1", |
There was a problem hiding this comment.
tsup major version bump with flexible range
tsup was previously pinned to 7.2.0; it's now ^8.5.1, a major-version bump with a caret that allows any 8.x patch to install. tsup v8 changed several defaults (e.g. treeshake is now on by default, splitting behaviour changed). Switching to a flexible range could produce different bundle output on different installs. Consider pinning to an exact version (8.5.1) or at least validating that the current build output is identical to the previous one.
| "tsup": "^8.5.1", | |
| "tsup": "8.5.1", |
| const result = await project.createWebPlatform({ | ||
| platformId: '<PLATFORM_ID>', | ||
| name: '<NAME>', | ||
| hostname: 'app.example.com' |
There was a problem hiding this comment.
Hmm notice here we have example value, but for other platforms we dont. can we add?
packageName, applicationId, bundleIdentifier, packageIdentifierName... they are all same, they can all be com.example.app I believe, Jake can confirm
This PR contains updates to the Node.js SDK for version 24.0.0.