Conversation
Greptile SummaryThis PR updates the PHP SDK to version 24.0.0, introducing three new services (
Confidence Score: 5/5This PR is safe to merge; changes are largely mechanical renames generated from the SDK spec and the new service implementations follow the established SDK patterns correctly. All three new services and their models are implemented consistently with the rest of the codebase. The breaking renames are intentional and clearly documented. The only concern is the parallel maintenance of Scopes.php and ProjectKeyScopes.php with identical values, which creates consumer confusion but does not break any runtime behavior. src/Appwrite/Enums/Scopes.php and src/Appwrite/Enums/ProjectKeyScopes.php — both were updated with the same new scope values, leaving their purpose ambiguous. Important Files Changed
Reviews (2): Last reviewed commit: "Merge branch 'main' into dev" | Re-trigger Greptile |
|
|
||
| namespace Appwrite\Models; | ||
|
|
||
| use Appwrite\Enums\OAuth2GooglePrompt; |
There was a problem hiding this comment.
Inconsistent enum:
OAuth2GooglePrompt vs ProjectOAuth2GooglePrompt
This PR introduces two newly-created, functionally identical enums — OAuth2GooglePrompt and ProjectOAuth2GooglePrompt — both containing the same three values (none, consent, select_account). The model hydrates prompt using OAuth2GooglePrompt, while Project.php imports ProjectOAuth2GooglePrompt. Given that all other enums in this PR adopt the Project* naming convention, the model should reference ProjectOAuth2GooglePrompt (and OAuth2GooglePrompt should be removed), or vice-versa. As-is, consumers see two interchangeable but distinct types for the same concept.
| use Appwrite\Enums\ProjectOAuth2GooglePrompt; | ||
| use Appwrite\Enums\ProjectOAuthProviderId; |
There was a problem hiding this comment.
Unused import
ProjectOAuth2GooglePrompt
ProjectOAuth2GooglePrompt is imported here, but updateOAuth2Google types the $prompt parameter as ?array — the import is never referenced as a type hint and will be flagged by static analysis tools.
| use Appwrite\Enums\ProjectOAuth2GooglePrompt; | |
| use Appwrite\Enums\ProjectOAuthProviderId; | |
| use Appwrite\Enums\ProjectOAuthProviderId; |
| use Appwrite\Enums\ProjectAuthMethodId; | ||
| use Appwrite\Enums\ProjectKeyScopes; |
There was a problem hiding this comment.
Unused import
ProjectKeyScopes
ProjectKeyScopes is imported but createKey, createEphemeralKey, and updateKey all type their $scopes parameter as plain array, so this import is never used as a type hint.
| use Appwrite\Enums\ProjectAuthMethodId; | |
| use Appwrite\Enums\ProjectKeyScopes; | |
| use Appwrite\Enums\ProjectAuthMethodId; |
# Conflicts: # CHANGELOG.md # docs/examples/project/update-o-auth-2-google.md # docs/project.md # src/Appwrite/Client.php # src/Appwrite/Services/Project.php # tests/Appwrite/Services/ProjectTest.php
This PR contains updates to the PHP SDK for version 24.0.0.
What's Changed
AuthMethodenum toProjectAuthMethodIdEmailTemplateTypetoProjectEmailTemplateIdandEmailTemplateLocaletoProjectEmailTemplateLocaleServiceIdtoProjectServiceId,ProtocolIdtoProjectProtocolId,SecuretoProjectSMTPSecure,ProjectPolicytoProjectPolicyIdScopesenum withProjectKeyScopesfor project key endpointsupdateDenyCanonicalEmailPolicy; replaced withupdateDenyAliasedEmailPolicy,updateDenyDisposableEmailPolicy, andupdateDenyFreeEmailPolicyAuthProvidermodel; use newProjectOAuthProviderIdenum insteadProject::getmethod to fetch current project detailsAdvisor,Presences, andUsageservicesInsight,Presence,Report,UsageEvent, andUsageGaugemodels with list variantsProjectAuthMethod,ProjectProtocol, andProjectServicemodelsProjectOAuthProviderIdandProjectOAuth2GooglePromptenumsProject,Database, andOAuth2Googlemodel schemasX-Appwrite-Response-Formatheader to1.9.5