feat: support concurrent chunk uploads#145
Conversation
Greptile SummaryThis PR replaces the sequential chunked-upload loop with a
Confidence Score: 4/5The core concurrent upload logic is structurally sound, but the unresolved final-result ambiguity from a prior review still applies, and the on_progress callback is invoked while holding the progress lock. The file-handle leak is fixed and the threading approach is reasonable. A previously flagged issue — where the returned result may not reflect the server's completion state when the finishing chunk arrives concurrently — remains unaddressed. The on_progress-under-lock pattern can silently degrade parallelism if callers do any work in the callback. appwrite/client.py — specifically the final-result selection logic and the progress-lock scope Important Files Changed
Reviews (2): Last reviewed commit: "feat: support concurrent chunk uploads" | Re-trigger Greptile |
This PR updates the SDK to support concurrent chunk uploads.