-
Notifications
You must be signed in to change notification settings - Fork 190
Fix issue that causes OAuth 2 Browser Popup to not close #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…auth_2 dependency
WalkthroughThe pull request updates the flutter_web_auth_2 dependency version constraint in the Flutter template pubspec configuration file from ^4.1.0 to ^5.0.0-alpha.3. This is a single dependency version bump with no modifications to other configuration values, dependencies, or control flow logic. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the flutter_web_auth_2 dependency from version ^4.1.0 to ^5.0.0-alpha.3 to fix a critical issue where OAuth 2.0 browser popups successfully authenticate but fail to close, leaving them in the foreground and blocking the user interface.
Key changes:
- Dependency version bump from
^4.1.0to^5.0.0-alpha.3forflutter_web_auth_2
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cookie_jar: ^4.0.8 | ||
| device_info_plus: '>=11.5.0 <13.0.0' | ||
| flutter_web_auth_2: ^4.1.0 | ||
| flutter_web_auth_2: ^5.0.0-alpha.3 |
Copilot
AI
Nov 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using an alpha pre-release version (^5.0.0-alpha.3) in production dependencies is risky and goes against best practices. Alpha versions are unstable, may contain bugs, and can introduce breaking changes without notice. Consider waiting for a stable 5.0.0 release or contact the flutter_web_auth_2 maintainers to expedite a stable release that includes the popup fix. If the alpha version must be used temporarily, add a comment explaining this is a temporary workaround and create a tracking issue to update to the stable version once released.
| flutter_web_auth_2: ^5.0.0-alpha.3 | |
| # TEMPORARY: Using alpha version for popup fix. See https://github.com/appwrite/sdk-generator/issues/XXXX | |
| flutter_web_auth_2: ^4.0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% needed in this case. Better to have it working but unstable rather than not working 😅
DH-555
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have manually tested this. Works fine in both dev and production.
What does this PR do?
This PR Upgrades the
flutter_web_auth_2dependency in the Flutter SDK. This fixes an issue with the library which caused OAuth 2.0 Browser Popups to return successfully but never close and stay on the foreground. This caused the app to be logged in but the Popup stayed in place.Test Plan
I verified this to be the fix for the Popup issue by using
flutter_web_auth_2: ^5.0.0-alpha.3as a dependency override in my app. Nothing else had been working to fix the issue, and this was the only thing that did.Related PRs and Issues
Resolves appwrite/sdk-for-flutter#285
More Information about the Issue can be found in the Discord Thread: https://discord.com/channels/564160730845151244/1438491539797049418
Have you read the Contributing Guidelines on issues?
yes
Summary by CodeRabbit