Skip to content

Fix issue that causes OAuth 2 Browser Popup to not close #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

Fix issue that causes OAuth 2 Browser Popup to not close #1254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/flutter/pubspec.yaml.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ dependencies:
sdk: flutter
cookie_jar: ^4.0.8
device_info_plus: '>=11.5.0 <13.0.0'
flutter_web_auth_2: ^4.1.0
flutter_web_auth_2: ^5.0.0-alpha.3
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an alpha pre-release version (^5.0.0-alpha.3) in production dependencies is risky and goes against best practices. Alpha versions are unstable, may contain bugs, and can introduce breaking changes without notice. Consider waiting for a stable 5.0.0 release or contact the flutter_web_auth_2 maintainers to expedite a stable release that includes the popup fix. If the alpha version must be used temporarily, add a comment explaining this is a temporary workaround and create a tracking issue to update to the stable version once released.

Suggested change
flutter_web_auth_2: ^5.0.0-alpha.3
# TEMPORARY: Using alpha version for popup fix. See https://github.com/appwrite/sdk-generator/issues/XXXX
flutter_web_auth_2: ^4.0.4

Copilot uses AI. Check for mistakes.
Copy link
Member

@DH-555 DH-555 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% needed in this case. Better to have it working but unstable rather than not working 😅

http: '>=0.13.6 <2.0.0'
package_info_plus: '>=8.0.2 <10.0.0'
path_provider: ^2.1.4
Expand Down
Loading