fix: misleading spec fetch error message in example.php#1478
Open
Parship12 wants to merge 1 commit intoappwrite:masterfrom
Open
fix: misleading spec fetch error message in example.php#1478Parship12 wants to merge 1 commit intoappwrite:masterfrom
Parship12 wants to merge 1 commit intoappwrite:masterfrom
Conversation
Signed-off-by: Parship Chowdhury <parshipchowdhury@gmail.com>
Greptile SummaryThis PR fixes a misleading error message in Confidence Score: 5/5Safe to merge — single-line error message fix with no logic or security implications. The change is purely a string correction in an error message; the logic, fetch URL, and surrounding code are untouched. No bugs or regressions introduced. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "change the err msg" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raw.githubusercontent.com is Github's CDN for raw file content... it has nothing to do with an Appwrite server. So, the error msg now accurately tells us where the fetch actually failed.
It isn't wrong, it's just misleading in the context of this codebase where "Appwrite server" has a very specific meaning to contributors. But now the fix will show it's a github fetch that failed, not something like the appwrite api being down.