Skip to content

Add codex plugin#1482

Open
adityaoberai wants to merge 13 commits intomasterfrom
codex-plugin
Open

Add codex plugin#1482
adityaoberai wants to merge 13 commits intomasterfrom
codex-plugin

Conversation

@adityaoberai
Copy link
Copy Markdown
Contributor

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

This PR adds a new CodexPlugin for generating OpenAI Codex CLI plugin scaffolding — including language SDK skills, deployment workflow skills, MCP server config, and a plugin manifest. It also migrates cursor-plugin/LICENSE.twig from MIT to BSD-3-Clause and updates the claude-plugin README to reference the license dynamically.

  • License metadata mismatch in claude-plugin/marketplace.json.twig: this PR changes the shared cursor-plugin/LICENSE.twig to BSD-3-Clause and example.php already passes licenseName: 'BSD-3-Clause' for the Claude plugin — but claude-plugin/marketplace.json.twig still hardcodes \"license\": \"MIT\", so the generated marketplace manifest will contradict the generated LICENSE file.

Confidence Score: 4/5

Safe to merge after fixing the license metadata mismatch in the Claude plugin marketplace manifest.

One P1 finding: the LICENSE template change to BSD-3-Clause isn't reflected in claude-plugin/marketplace.json.twig, which still hardcodes MIT. All other issues were flagged in prior review threads. No security concerns.

templates/claude-plugin/marketplace.json.twig — hardcoded "MIT" license contradicts the BSD-3-Clause LICENSE file now generated by ClaudePlugin.

Important Files Changed

Filename Overview
templates/claude-plugin/marketplace.json.twig Not changed in this PR, but now has a P1 mismatch: hardcodes "license": "MIT" while this PR moves cursor-plugin/LICENSE.twig to BSD-3-Clause, which ClaudePlugin also uses.
src/SDK/Language/CodexPlugin.php New plugin class extending AgentSkills; correctly reuses agent-skills templates and sets output paths under plugins/appwrite/. No functional defects in the PHP itself.
templates/cursor-plugin/LICENSE.twig Changed from MIT to BSD-3-Clause; also used by ClaudePlugin, creating a downstream mismatch in claude-plugin/marketplace.json.twig.
templates/codex-plugin/plugin.json.twig Plugin manifest; repository URL and license are now templated. Relative paths ../skills/ and ../.mcp.json are correct given plugin.json lives at plugins/appwrite/.codex-plugin/.
templates/codex-plugin/marketplace.json.twig Marketplace manifest generated at .agents/plugins/marketplace.json; path "./plugins/appwrite" may resolve incorrectly if Codex CLI resolves it relative to the manifest file rather than the repo root (pre-existing concern).
templates/codex-plugin/README.md.twig Comprehensive README; install paths correctly reference plugins/appwrite/skills/ and plugins/appwrite/config.toml throughout.
templates/codex-plugin/skills/deploy-function.md.twig Deploy-function skill with complete CLI command reference; delete-variable correctly includes --variable-id.
templates/codex-plugin/skills/deploy-site.md.twig Deploy-site skill; delete-variable command is missing --variable-id (flagged in prior review thread).
templates/codex-plugin/config.toml.twig Correct TOML config snippet for Codex CLI; two MCP server entries with placeholder values.
templates/codex-plugin/.mcp.json.twig MCP server config with stdio and http entries; looks correct.
templates/claude-plugin/README.md.twig License reference updated from hardcoded MIT to dynamic {{spec.licenseName}}/{{spec.licenseURL}}.

Comments Outside Diff (1)

  1. templates/claude-plugin/marketplace.json.twig, line 22 (link)

    P1 Hardcoded MIT license contradicts the BSD-3-Clause LICENSE file

    This PR changes cursor-plugin/LICENSE.twig from MIT to BSD-3-Clause. ClaudePlugin uses that template for its generated LICENSE file and example.php already passes licenseName: 'BSD-3-Clause' for the Claude plugin. After this PR the generated repo will contain a BSD-3-Clause LICENSE file while this marketplace manifest still declares "MIT", making the metadata factually wrong.

Reviews (11): Last reviewed commit: "Reflect correct plugin directory structu..." | Re-trigger Greptile

Comment thread templates/codex-plugin/skills/deploy-site.md.twig Outdated
Comment thread templates/codex-plugin/plugin.json.twig Outdated
Comment thread templates/codex-plugin/skills/cli.md.twig Outdated
adityaoberai and others added 4 commits April 28, 2026 21:46
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Comment thread templates/codex-plugin/skills/cli.md.twig Outdated
Comment thread templates/codex-plugin/plugin.json.twig Outdated
Comment thread templates/codex-plugin/marketplace.json.twig
Comment thread templates/codex-plugin/plugin.json.twig Outdated
Comment thread templates/codex-plugin/README.md.twig
adityaoberai and others added 2 commits April 30, 2026 02:20
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants