You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR narrows the brace-expansion npm override from a global rule to one scoped under glob, preventing the override from forcing serve-handler onto the ESM-only brace-expansion@5.x it cannot use. The lock file is regenerated accordingly.
package.json.twig: replaces "brace-expansion": "^5.0.6" at the top-level overrides with a nested glob object ("." pins glob itself to ^13, brace-expansion beneath it pins the transitive dep to ^5.0.6). This is the correct npm overrides syntax for scoping a transitive dependency to a single parent.
package-lock.json.twig: top-level brace-expansion@5/balanced-match@4 entries gain "peer": true (they are now only reachable via a peer-dep chain through expo→glob), and three new nested entries under serve-handler (brace-expansion@1.1.14, balanced-match@1.0.2, concat-map@0.0.1) restore the CommonJS-compatible version that serve-handler requires.
Confidence Score: 5/5
Safe to merge; the change is a targeted, well-contained dependency-resolution fix with no production code altered.
Both the package.json.twig override scoping (using the npm-documented . self-reference syntax) and the corresponding lock file regeneration are consistent and correct. serve-handler regains its own brace-expansion@1.1.14 tree, and glob continues to resolve brace-expansion@5. No logic or generated-SDK code is affected.
No files require special attention.
Important Files Changed
Filename
Overview
templates/react-native/package.json.twig
Scopes the brace-expansion override to only apply within glob's dependency tree, removing the global override that was inadvertently forcing serve-handler onto an incompatible ESM-only version.
templates/react-native/package-lock.json.twig
Lock file regenerated to reflect the scoped override: top-level brace-expansion@5 and balanced-match@4 are now marked peer, and serve-handler gets its own nested brace-expansion@1.1.14 + balanced-match@1.0.2 + concat-map@0.0.1 entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Testing