Conversation
2 tasks
Member
lohanidamodar
left a comment
lohanidamodar
left a comment
There was a problem hiding this comment.
Looks good, small query
| } | ||
| } | ||
|
|
||
| const deploySettings = async ({ yes } = {}) => { |
Member
There was a problem hiding this comment.
Should we seprate these settings into individual deploys? Might be confusing as these are independent settings?
Contributor
Author
There was a problem hiding this comment.
We currently apply:
- OAuth enable/disable
- Services enable/disable
- Max users limit
I can see how it would be useful to only specify one of them to deploy. I can implement a similar passion to what we do in deploy functions where you either select ones to deploy manually, or do --all to auto-pick all of them. Sounds good?
Member
There was a problem hiding this comment.
yes that sounds good, otherwise people might be confused as to what settings will be deployed, initialized
Member
|
Skipping it for now, closing, we can reopen if we want to go ahead with this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As implemented by init&deploy collection, this PR adds the same logic for project settings. It' common practice to have a predefined structure of a project (enabled services, auth methods, users limit), just like it's common for databases. Since appwrite.json is supposed to be a source of truth for initial setup of Appwrite project, it should project settings.
This PR gets us one small step closer to "Deploy to Appwrite" 1-click setup.
Settings include:
Test Plan
CleanShot.2022-10-01.at.20.24.34.mp4
Related PRs and Issues
x
Have you read the Contributing Guidelines on issues?
Yes