Skip to content

Change pricing comp for changelog#2976

Merged
eldadfux merged 2 commits into
mainfrom
fix/docs-cls-toc-multicode
May 7, 2026
Merged

Change pricing comp for changelog#2976
eldadfux merged 2 commits into
mainfrom
fix/docs-cls-toc-multicode

Conversation

@eldadfux
Copy link
Copy Markdown
Member

@eldadfux eldadfux commented May 6, 2026

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

eldadfux added 2 commits May 6, 2026 17:06
- Added `aria-haspopup="menu"` attribute to the ProductsSubmenu component for improved accessibility.
- Removed PreFooter component from changelog pages and integrated Pricing component for better layout and user engagement.
- Adjusted the structure of the changelog entry pages to maintain a consistent design and improve overall user experience.

These changes aim to enhance accessibility and streamline the layout of the changelog sections.
…yout

- Introduced an `embedded` prop to the Pricing component, allowing for conditional rendering of background animations based on layout requirements.
- Updated instances of the Pricing component in changelog pages to utilize the new `embedded` prop, enhancing layout consistency and visual appeal.

These changes improve the adaptability of the Pricing component in various contexts.
@appwrite
Copy link
Copy Markdown

appwrite Bot commented May 6, 2026

Appwrite Website

Project ID: 69d7efb00023389e8d27

Sites (1)
Site Status Logs Preview QR
 website
69d7f2670014e24571ca
Building Building View Logs Preview URL QR Code

Website (appwrite/website)

Project ID: 684969cb000a2f6c0a02

Sites (1)
Site Status Logs Preview QR
 website
68496a17000f03d62013
Building Building View Logs Preview URL QR Code


Tip

Function builds can take up to 45 minutes before timing out

@eldadfux eldadfux changed the title Fix/docs cls toc multicode Change pricing comp for changelog May 6, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 6, 2026

Greptile Summary

This PR replaces the PreFooter component on both changelog pages with an embedded Pricing component, and adds an aria-haspopup="menu" attribute to the products submenu trigger. The Pricing component gains a new embedded prop that suppresses its animated lighting background for tighter layouts.

  • pricing.svelte: New embedded boolean prop (default false) conditionally omits the decorative animated div; class overrides passed by callers are safely resolved via tailwind-merge inside cn().
  • Changelog pages ([[page]] and entry/[entry]): PreFooter removed and replaced with <Pricing embedded …> using custom spacing classes; FooterNav and MainFooter are preserved beneath it.
  • ProductsSubmenu.svelte: aria-haspopup="menu" added to the trigger element for improved screen-reader semantics.

Confidence Score: 5/5

All changes are isolated UI/layout updates with no logic, data, or auth paths affected — safe to merge.

The diff touches only presentation concerns: swapping a decorative footer component for an embedded pricing block, hiding an animation in compact contexts, and adding an ARIA attribute. The class-override mechanism relies on tailwind-merge (confirmed in cn.ts), so there is no risk of conflicting utility classes leaking through. No logic, routing, data fetching, or shared state is altered.

No files require special attention.

Important Files Changed

Filename Overview
src/lib/components/ProductsSubmenu.svelte Adds aria-haspopup="menu" to the submenu trigger element — a straightforward accessibility improvement.
src/routes/(marketing)/(components)/pricing.svelte Adds optional embedded prop (default false) that suppresses the animated lighting background; class overrides are safe because cn() uses tailwind-merge.
src/routes/changelog/[[page]]/+page.svelte Replaces PreFooter with embedded Pricing component above FooterNav/MainFooter; layout classes look correct.
src/routes/changelog/entry/[entry]/+page.svelte Same PreFooter → embedded Pricing swap as the list page; no issues found.

Reviews (1): Last reviewed commit: "feat(pricing): add embedded prop to Pric..." | Re-trigger Greptile

@eldadfux eldadfux merged commit fb6fd67 into main May 7, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant