Import * as Transport/Utils, then export#33
Closed
jackbmccarthy wants to merge 1 commit into
Closed
Conversation
This is a minor change, I am using Acebase in an Expo project, but the bundler doesn't support the "export * as NAME from './file'" syntax. This change would make it so that Expo would be able to use acebase-client, without needing to change the node_modules folder manually.
Owner
|
@jackbmccarthy Although this is a small change, have you considered bringing this to the attention of the bundler's team? Sounds like something they should fix instead of the authors of all possible packages you might be bundling! |
Owner
|
Just came across this again, maybe you are using an older TypeScript version than 3.8? See https://www.typescriptlang.org/docs/handbook/modules.html#export-all-as-x ("With TypeScript 3.8, you can use |
Author
|
The issue is that the Babel Presets used for Expo doesn't support that syntax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor change, I am using Acebase in an Expo project, but the bundler doesn't support the "export * as NAME from './file'" syntax. This change would make it so that Expo would be able to use acebase-client, without needing to change the node_modules folder manually.