Merged
Conversation
Member
|
Hola @santroma1: Para que te acepte el pull request, debes enviarme un commit después de este comentario ¡quedo a la espera! :-) |
Contributor
Author
|
Listo!, ya agregue un commit en mi branch mycommits |
Member
|
Si te fijas esta conversación verás que aparece el primer commit que hiciste (5923b16) pero no aparece ninguno más. En la pestaña commits solo aparece el primer commit. Si has creado un segundo commit y no aparace aquí es porque no has hecho push. Recuerda que debes hacer el segundo commit en la rama mycommits y hacer push de esa rama. Entonces lo verás aquí... y te apruebo el pull request 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAN