Added functionality to store user password in system keychain (safe, encrypted)#4
Merged
apsknight merged 3 commits intoapsknight:masterfrom Jan 4, 2019
madhavtummala:master
Merged
Added functionality to store user password in system keychain (safe, encrypted)#4apsknight merged 3 commits intoapsknight:masterfrom madhavtummala:master
apsknight merged 3 commits intoapsknight:masterfrom
madhavtummala:master
Conversation
Owner
|
Thanks for adding this feature. I think this also solves #3 opened by @mathamonkey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of macOS, the user will be asked whether to store the password for ERP, against the given username. If the password already exists in the keychain, the attendance will directly be displayed.
Since the passwords are being handled by system managers, it is very safe. For other operating systems the respective system keychains will be used. See here for more info on it.