docs: record spanenc adoption boundary (#233)#235
Conversation
Document that reflection-based, client encodeValue-compatible Go value → GCV conversion lives in spanenc; gcvctor stays explicit strict constructors. Add pkg.go.dev discoverability pointer from gcvctor to spanenc. Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in AGENTS.md and gcvctor/doc.go to clarify the separation of concerns between gcvctor and the new spanenc package. Specifically, it notes that reflection and client-tag Go value to GCV conversion (including struct tags, null wrappers, and encoder semantics) live in spanenc, while gcvctor remains focused on explicit, strict constructors. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
apstndb
left a comment
apstndb
left a comment
There was a problem hiding this comment.
Reviewed from the spanenc side — both changes say exactly what #233 asked for: the AGENTS.md boundary line keeps reflection/client-tag feature requests out of gcvctor with a recorded answer, and the gcvctor doc pointer gives pkg.go.dev visitors the route to the client-semantics layer. The parenthetical (struct tags, null wrappers, Encoder) matches spanenc's actual coverage. LGTM as the issue filer; one optional inline note.
Clarify why structfields is a separate module from spanenc/gcvctor. Co-authored-by: Cursor <cursoragent@cursor.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in AGENTS.md and gcvctor/doc.go to reference the new spanenc and structfields modules for converting arbitrary Go values with official Cloud Spanner Go client encoding semantics. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Summary
Requested by spanenc downstream feedback.
Test plan
make checkCloses #233
Made with Cursor