Enable Gamma Russian Roulette as ATLAS SteppingAction#545
Merged
SeverinDiederichs merged 5 commits intoapt-sim:masterfrom Apr 20, 2026
Merged
Conversation
|
Can one of the admins verify this patch? |
436b4cc to
8e09ce1
Compare
Collaborator
Author
|
/run-test |
agheata
approved these changes
Apr 20, 2026
Contributor
agheata
left a comment
There was a problem hiding this comment.
Thanks for this important addition. As discussed offline, the new photon roulette only preserves expectation for unit-weight parents, but this is how it is done in ATLAS so it has to match, propose a fix in Athena and only after update in AdePT. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the gamma Russian Roulette for ATLAS and resolves #532.
The Russian Roulette is implemented as a SteppingAction: if active (
-DADEPT_STEPPINGACTION=ATLAS), before a gamma is created, it will undergo RR. The settings for the energy threshold and probability are hardcoded for now, as the default parameters in Athena. One important difference: Athena checks for the placed volume prefix "LAr" while AdePT does this at the logical volume level. A safety check is added, and it does not trigger in Athena, in case a placed volume would be created without the LAr prefix, while the logical volume had one.Notes:
Performance results:
Run on the RTX4090
Mono_MasterMono_NoRRMono_GammaRRSplit_MasterSplit_NoRRSplit_GammaRRG4HepEmValidation:

The results in Athena with both monolithic and split kernels look good with the Russian Roulette turned on.
To do:
For an upcoming PR: